Skip to content

Commit 21eeb31

Browse files
jukzijukzi
committed
remove unchecked warnings
Depending on the amount of warnings on project the warning has been disabled, Suppressed or solved To get a clean Problems View on ancient code
1 parent 21347e8 commit 21eeb31

29 files changed

+246
-29
lines changed

‎team/bundles/org.eclipse.compare.win32/.settings/org.eclipse.jdt.core.prefs‎

Lines changed: 103 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
23
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
34
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
45
org.eclipse.jdt.core.builder.invalidClasspath=abort
@@ -7,6 +8,15 @@ org.eclipse.jdt.core.builder.resourceCopyExclusionFilter=*.launch
78
org.eclipse.jdt.core.circularClasspath=error
89
org.eclipse.jdt.core.classpath.exclusionPatterns=enabled
910
org.eclipse.jdt.core.classpath.multipleOutputLocations=enabled
11+
org.eclipse.jdt.core.compiler.annotation.inheritNullAnnotations=disabled
12+
org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore
13+
org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull
14+
org.eclipse.jdt.core.compiler.annotation.nonnull.secondary=
15+
org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault
16+
org.eclipse.jdt.core.compiler.annotation.nonnullbydefault.secondary=
17+
org.eclipse.jdt.core.compiler.annotation.nullable=org.eclipse.jdt.annotation.Nullable
18+
org.eclipse.jdt.core.compiler.annotation.nullable.secondary=
19+
org.eclipse.jdt.core.compiler.annotation.nullanalysis=disabled
1020
org.eclipse.jdt.core.compiler.codegen.inlineJsrBytecode=enabled
1121
org.eclipse.jdt.core.compiler.codegen.methodParameters=do not generate
1222
org.eclipse.jdt.core.compiler.codegen.targetPlatform=17
@@ -16,8 +26,101 @@ org.eclipse.jdt.core.compiler.debug.lineNumber=generate
1626
org.eclipse.jdt.core.compiler.debug.localVariable=generate
1727
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
1828
org.eclipse.jdt.core.compiler.maxProblemPerUnit=100
29+
org.eclipse.jdt.core.compiler.problem.APILeak=warning
30+
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
31+
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
1932
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
33+
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
34+
org.eclipse.jdt.core.compiler.problem.comparingIdentical=warning
35+
org.eclipse.jdt.core.compiler.problem.deadCode=warning
36+
org.eclipse.jdt.core.compiler.problem.deprecation=warning
37+
org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode=disabled
38+
org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod=disabled
39+
org.eclipse.jdt.core.compiler.problem.discouragedReference=warning
40+
org.eclipse.jdt.core.compiler.problem.emptyStatement=ignore
2041
org.eclipse.jdt.core.compiler.problem.enumIdentifier=error
42+
org.eclipse.jdt.core.compiler.problem.explicitlyClosedAutoCloseable=ignore
43+
org.eclipse.jdt.core.compiler.problem.fallthroughCase=ignore
44+
org.eclipse.jdt.core.compiler.problem.fatalOptionalError=disabled
45+
org.eclipse.jdt.core.compiler.problem.fieldHiding=ignore
46+
org.eclipse.jdt.core.compiler.problem.finalParameterBound=warning
47+
org.eclipse.jdt.core.compiler.problem.finallyBlockNotCompletingNormally=warning
48+
org.eclipse.jdt.core.compiler.problem.forbiddenReference=warning
49+
org.eclipse.jdt.core.compiler.problem.hiddenCatchBlock=warning
50+
org.eclipse.jdt.core.compiler.problem.includeNullInfoFromAsserts=disabled
51+
org.eclipse.jdt.core.compiler.problem.incompatibleNonInheritedInterfaceMethod=warning
52+
org.eclipse.jdt.core.compiler.problem.incompleteEnumSwitch=warning
53+
org.eclipse.jdt.core.compiler.problem.indirectStaticAccess=ignore
54+
org.eclipse.jdt.core.compiler.problem.localVariableHiding=ignore
55+
org.eclipse.jdt.core.compiler.problem.methodWithConstructorName=warning
56+
org.eclipse.jdt.core.compiler.problem.missingDefaultCase=ignore
57+
org.eclipse.jdt.core.compiler.problem.missingDeprecatedAnnotation=ignore
58+
org.eclipse.jdt.core.compiler.problem.missingEnumCaseDespiteDefault=disabled
59+
org.eclipse.jdt.core.compiler.problem.missingHashCodeMethod=ignore
60+
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotation=ignore
61+
org.eclipse.jdt.core.compiler.problem.missingOverrideAnnotationForInterfaceMethodImplementation=enabled
62+
org.eclipse.jdt.core.compiler.problem.missingSerialVersion=warning
63+
org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignore
64+
org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning
65+
org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
66+
org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
67+
org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=warning
68+
org.eclipse.jdt.core.compiler.problem.nonnullTypeVariableFromLegacyInvocation=warning
69+
org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error
70+
org.eclipse.jdt.core.compiler.problem.nullReference=warning
71+
org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
72+
org.eclipse.jdt.core.compiler.problem.nullUncheckedConversion=warning
73+
org.eclipse.jdt.core.compiler.problem.overridingPackageDefaultMethod=warning
74+
org.eclipse.jdt.core.compiler.problem.parameterAssignment=ignore
75+
org.eclipse.jdt.core.compiler.problem.pessimisticNullAnalysisForFreeTypeVariables=warning
76+
org.eclipse.jdt.core.compiler.problem.possibleAccidentalBooleanAssignment=ignore
77+
org.eclipse.jdt.core.compiler.problem.potentialNullReference=ignore
78+
org.eclipse.jdt.core.compiler.problem.potentiallyUnclosedCloseable=ignore
79+
org.eclipse.jdt.core.compiler.problem.rawTypeReference=warning
80+
org.eclipse.jdt.core.compiler.problem.redundantNullAnnotation=warning
81+
org.eclipse.jdt.core.compiler.problem.redundantNullCheck=ignore
82+
org.eclipse.jdt.core.compiler.problem.redundantSpecificationOfTypeArguments=ignore
83+
org.eclipse.jdt.core.compiler.problem.redundantSuperinterface=ignore
84+
org.eclipse.jdt.core.compiler.problem.reportMethodCanBePotentiallyStatic=ignore
85+
org.eclipse.jdt.core.compiler.problem.reportMethodCanBeStatic=ignore
86+
org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
87+
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
88+
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled
89+
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
90+
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=info
91+
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
92+
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
93+
org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning
94+
org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
95+
org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled
96+
org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=ignore
97+
org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning
98+
org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
99+
org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
100+
org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentType=warning
101+
org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentTypeStrict=disabled
102+
org.eclipse.jdt.core.compiler.problem.unlikelyEqualsArgumentType=info
103+
org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
104+
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore
105+
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
106+
org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=warning
107+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore
108+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
109+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled
110+
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionWhenOverriding=disabled
111+
org.eclipse.jdt.core.compiler.problem.unusedExceptionParameter=ignore
112+
org.eclipse.jdt.core.compiler.problem.unusedImport=warning
113+
org.eclipse.jdt.core.compiler.problem.unusedLabel=warning
114+
org.eclipse.jdt.core.compiler.problem.unusedLocal=warning
115+
org.eclipse.jdt.core.compiler.problem.unusedObjectAllocation=ignore
116+
org.eclipse.jdt.core.compiler.problem.unusedParameter=ignore
117+
org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=enabled
118+
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
119+
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
120+
org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning
121+
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore
122+
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
123+
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
21124
org.eclipse.jdt.core.compiler.source=17
22125
org.eclipse.jdt.core.incompatibleJDKLevel=ignore
23126
org.eclipse.jdt.core.incompleteClasspath=error

‎team/bundles/org.eclipse.compare.win32/src/org/eclipse/compare/internal/win32/WordComparison.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ protected void initializeWorkbenchMenus(IWorkbenchWindow window) {
429429
// Swap the file and window menus.
430430
MenuItem[] windowMenu = new MenuItem[1];
431431
MenuItem[] fileMenu = new MenuItem[1];
432-
Vector containerItems = new Vector();
432+
Vector<MenuItem> containerItems = new Vector<>();
433433

434434
for (int i = 0; i < menuBar.getItemCount(); i++) {
435435
MenuItem item = menuBar.getItem(i);

‎team/bundles/org.eclipse.compare.win32/src/org/eclipse/compare/internal/win32/WordMergeViewer.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public class WordMergeViewer extends AbstractMergeViewer implements IFlushable,
7474
private Label description;
7575
private WordComparison wordArea;
7676
private boolean isDirty;
77-
private final ListenerList listeners = new ListenerList(ListenerList.IDENTITY);
77+
private final ListenerList<IPropertyChangeListener> listeners = new ListenerList<>(ListenerList.IDENTITY);
7878
private Action saveAction;
7979
private ResourceBundle resourceBundle;
8080
private Action inplaceAction;

‎team/bundles/org.eclipse.team.ui/.settings/org.eclipse.jdt.core.prefs‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.builder.annotationPath.allLocations=disabled
23
org.eclipse.jdt.core.builder.cleanOutputFolder=clean
34
org.eclipse.jdt.core.builder.duplicateResourceTask=warning
45
org.eclipse.jdt.core.builder.invalidClasspath=abort
@@ -26,6 +27,8 @@ org.eclipse.jdt.core.compiler.debug.localVariable=generate
2627
org.eclipse.jdt.core.compiler.debug.sourceFile=generate
2728
org.eclipse.jdt.core.compiler.doc.comment.support=enabled
2829
org.eclipse.jdt.core.compiler.maxProblemPerUnit=100
30+
org.eclipse.jdt.core.compiler.problem.APILeak=warning
31+
org.eclipse.jdt.core.compiler.problem.annotatedTypeArgumentToUnannotated=info
2932
org.eclipse.jdt.core.compiler.problem.annotationSuperInterface=warning
3033
org.eclipse.jdt.core.compiler.problem.assertIdentifier=error
3134
org.eclipse.jdt.core.compiler.problem.autoboxing=ignore
@@ -98,17 +101,23 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
98101
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=error
99102
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled
100103
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
104+
org.eclipse.jdt.core.compiler.problem.suppressWarningsNotFullyAnalysed=info
101105
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
102106
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
107+
org.eclipse.jdt.core.compiler.problem.terminalDeprecation=warning
103108
org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
104109
org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled
105-
org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=warning
110+
org.eclipse.jdt.core.compiler.problem.uncheckedTypeOperation=ignore
106111
org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning
107112
org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
108113
org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
114+
org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentType=warning
115+
org.eclipse.jdt.core.compiler.problem.unlikelyCollectionMethodArgumentTypeStrict=disabled
116+
org.eclipse.jdt.core.compiler.problem.unlikelyEqualsArgumentType=info
109117
org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
110118
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning
111119
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
120+
org.eclipse.jdt.core.compiler.problem.unstableAutoModuleName=warning
112121
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore
113122
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
114123
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionIncludeDocCommentReference=enabled

‎team/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/StorageTypedElement.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ public String getCharset() throws CoreException {
110110
return null;
111111
}
112112

113-
@SuppressWarnings("unchecked")
114113
@Override
115114
public <T> T getAdapter(Class<T> adapter) {
116115
if (adapter == ISharedDocumentAdapter.class) {

‎team/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/TeamAdapterFactory.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ public class TeamAdapterFactory implements IAdapterFactory {
4343

4444
private static final ISynchronizationCompareAdapter COMPARE_ADAPTER = new ResourceModelPersistenceAdapter();
4545

46-
@SuppressWarnings("unchecked")
4746
@Override
4847
public <T> T getAdapter(Object adaptableObject, Class<T> adapterType) {
4948
if(adaptableObject instanceof DiffNode && adapterType == IWorkbenchAdapter.class) {

‎team/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/actions/TeamAction.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,6 @@ public void partVisible(IWorkbenchPartReference partRef) {
142142
*
143143
* @return the selected adaptables
144144
*/
145-
@SuppressWarnings("unchecked")
146145
public static <T> T[] getSelectedAdaptables(ISelection selection, Class<T> c) {
147146
ArrayList<T> result = null;
148147
if (selection != null && !selection.isEmpty()) {
@@ -168,7 +167,6 @@ public static <T> T[] getSelectedAdaptables(ISelection selection, Class<T> c) {
168167
*
169168
* @return Object
170169
*/
171-
@SuppressWarnings("unchecked")
172170
public static <T> T getAdapter(Object adaptable, Class<T> c) {
173171
if (c.isInstance(adaptable)) {
174172
return (T) adaptable;

‎team/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/dialogs/ResourceMappingResourceDisplayArea.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,6 @@ public Object getParent(Object o) {
139139
}
140140

141141
@Override
142-
@SuppressWarnings("unchecked")
143142
public <T> T getAdapter(Class<T> adapter) {
144143
if (adapter == IWorkbenchAdapter.class)
145144
return (T) this;
@@ -227,7 +226,6 @@ public Object getParent(Object o) {
227226
}
228227

229228
@Override
230-
@SuppressWarnings("unchecked")
231229
public <T> T getAdapter(Class<T> adapter) {
232230
if (adapter == IWorkbenchAdapter.class)
233231
return (T) this;

‎team/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/CompareFileRevisionEditorInput.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,6 @@ public String getTitle() {
239239
return NLS.bind(TeamUIMessages.CompareFileRevisionEditorInput_compareResourceAndVersions, titleObject);
240240
}
241241

242-
@SuppressWarnings("unchecked")
243242
@Override
244243
public <T> T getAdapter(Class<T> adapter) {
245244
if (adapter == IFile.class || adapter == IResource.class) {

‎team/bundles/org.eclipse.team.ui/src/org/eclipse/team/internal/ui/history/FileRevisionEditorInput.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ public String getToolTipText() {
189189
}
190190

191191
@Override
192-
@SuppressWarnings("unchecked")
193192
public <T> T getAdapter(Class<T> adapter) {
194193
if (adapter == IWorkbenchAdapter.class)
195194
return (T) this;

0 commit comments

Comments
 (0)