Skip to content

Commit c04712a

Browse files
HeikoKlarefedejeanne
authored andcommitted
Replace obsolete reflective access with direct field access
A reflective field access has been used for backward compatibility with Eclipse 3.4 for a field introduced with Eclispe 3.6. Since this is long ago, the reflective call can be replaced with a direct field access.
1 parent 79495b8 commit c04712a

1 file changed

Lines changed: 1 addition & 13 deletions

File tree

terminal/bundles/org.eclipse.terminal.control/src/org/eclipse/terminal/internal/emulator/VT100TerminalControl.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import java.io.IOException;
4949
import java.io.InputStreamReader;
5050
import java.io.OutputStream;
51-
import java.lang.reflect.Field;
5251
import java.net.SocketException;
5352
import java.nio.charset.Charset;
5453
import java.util.EnumMap;
@@ -1242,18 +1241,7 @@ private void processKeyBinding(KeyEvent event, int accelerator) {
12421241
cmdEvent.widget = event.widget;
12431242
cmdEvent.character = event.character;
12441243
cmdEvent.keyCode = event.keyCode;
1245-
////Bug - KeyEvent.keyLocation was introduced in Eclipse 3.6
1246-
////Use reflection for now to remain backward compatible down to Eclipse 3.4
1247-
//cmdEvent.keyLocation = event.keyLocation;
1248-
try {
1249-
Field f1 = event.getClass().getField("keyLocation"); //$NON-NLS-1$
1250-
Field f2 = cmdEvent.getClass().getField("keyLocation"); //$NON-NLS-1$
1251-
f2.set(cmdEvent, f1.get(event));
1252-
} catch (NoSuchFieldException nsfe) {
1253-
/* ignore, this is Eclipse 3.5 or earlier */
1254-
} catch (Throwable t) {
1255-
t.printStackTrace();
1256-
}
1244+
cmdEvent.keyLocation = event.keyLocation;
12571245
cmdEvent.stateMask = event.stateMask;
12581246
event.doit = false;
12591247
try {

0 commit comments

Comments
 (0)