Help: Embedded Browser: Make 'needModal' workaround more robust

[sratz]

See #1822

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ua/org.eclipse.help.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From e0e80b220f1fd156a1415672a1ad5a4bff84f974 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 11 Apr 2025 07:51:06 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
index aaac5dfae1..56ae785504 100644
--- a/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.help.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %help_system_plugin_name
 Bundle-SymbolicName: org.eclipse.help.ui; singleton:=true
-Bundle-Version: 4.8.0.qualifier
+Bundle-Version: 4.8.100.qualifier
 Bundle-Activator: org.eclipse.help.ui.internal.HelpUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

 1 758 files  ±0   1 758 suites  ±0   1h 29m 54s ⏱️ - 4m 0s
 4 173 tests ±0   4 150 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 119 runs  ±0  12 952 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 0fee368. ± Comparison against base commit a7c5c52.

♻️ This comment has been updated with latest results.

Actually, lets wait until the tests run. It's taking more than 1 hour to run the tests

[fedejeanne]

The code LGTM and a manual test indicates that it works as expected, both for IE and Edge on Windows. But the Windows Tests are taking forever. Let's wait and see if that is related to this change or if it is an infrastructure issue

[sratz]

[...] if that is related to this change or if it is an infrastructure issue

Looks like it is. It's failing with java.lang.OutOfMemoryError: Java heap space in org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.13-SNAPSHOT:compare-version-with-baselines

[sratz]

Pretty much every Continuous Integration / build / Verify Windows (push) has been failing recently:
https://github.com/eclipse-platform/eclipse.platform/commits/master/

Looks like there is something fundamentally wrong with the runner used by the GitHub action.

Current runner version: '2.323.0'
Operating System
  Microsoft Windows Server [2](https://github.com/eclipse-platform/eclipse.platform/actions/runs/14176673310/job/39713129666#step:1:2)022
  10.0.20348
  Datacenter
Runner Image
  Image: windows-2022
  Version: 20250[3](https://github.com/eclipse-platform/eclipse.platform/actions/runs/14176673310/job/39713129666#step:1:3)24.3.0
  Included Software: https://github.com/actions/runner-images/blob/win22/2025032[4](https://github.com/eclipse-platform/eclipse.platform/actions/runs/14176673310/job/39713129666#step:1:4).3/images/windows/Windows2022-Readme.md
  Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F202[5](https://github.com/eclipse-platform/eclipse.platform/actions/runs/14176673310/job/39713129666#step:1:5)0324.3
Runner Image Provisioner
  2.0.422.1

I can't see what specs it has but the max heap size seems small:

   size_t MaxHeapSize                              = 1572864000                                {product} {command line}

@HannesWell: do you have an idea what might be wrong here? Where is the heap size limited to 1.5GB?

[sratz]

Found it, let's see if #1809 helps