Remove hover and duplicate image descriptors in org.eclipse.ui.debug#1839
Merged
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom Apr 26, 2025
Merged
Conversation
HeikoKlare
force-pushed
the
hover-org.eclipse.debug.ui
branch
from
42ba681 to
62337f6
Compare
Contributor
HeikoKlare
force-pushed
the
hover-org.eclipse.debug.ui
branch
from
62337f6 to
b52fbba
Compare
HeikoKlare
force-pushed
the
hover-org.eclipse.debug.ui
branch
2 times, most recently
from
8f382a9 to
770c027
Compare
In org.eclipse.ui.debug, a bunch of descriptors refer to the same files, thus leading to duplicate resources in JFace's resource manager even though the same image is used. In addition, hover images are explicitly set to the same image as the original image in many cases. This change removes the unnecessary hover image specifications and de-duplicates the image descriptors to save resources.
HeikoKlare
force-pushed
the
hover-org.eclipse.debug.ui
branch
from
3dbec0e to
a74956d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In org.eclipse.ui.debug, a bunch of descriptors refer to the same files, thus leading to duplicate resources in JFace's resource manager even though the same image is used. In addition, hover images are explicitly set to the same image as the original image in many cases.
This change removes the unnecessary hover image specifications and de-duplicates the image descriptors to save resources.