Skip to content

Simplify NLS.bind() invocations in jsch integration#1854

Merged
HannesWell merged 2 commits intoeclipse-platform:masterfrom
HannesWell:simplify-NLS.bind-in-jsch
May 4, 2025
Merged

Simplify NLS.bind() invocations in jsch integration#1854
HannesWell merged 2 commits intoeclipse-platform:masterfrom
HannesWell:simplify-NLS.bind-in-jsch

Conversation

@HannesWell
Copy link
Copy Markdown
Member

This also avoid compilation errors due to some source incompatible cases of:

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

team/bundles/org.eclipse.jsch.core/META-INF/MANIFEST.MF
team/bundles/org.eclipse.jsch.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 14aefcbe1d25c1175fa4c10824c42174221fb2ed Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sun, 4 May 2025 22:03:14 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/team/bundles/org.eclipse.jsch.core/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.jsch.core/META-INF/MANIFEST.MF
index 8d32394a09..7105e6cd8b 100644
--- a/team/bundles/org.eclipse.jsch.core/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.jsch.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jsch.core;singleton:=true
-Bundle-Version: 1.5.500.qualifier
+Bundle-Version: 1.5.600.qualifier
 Bundle-Activator: org.eclipse.jsch.internal.core.JSchCorePlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/team/bundles/org.eclipse.jsch.ui/META-INF/MANIFEST.MF b/team/bundles/org.eclipse.jsch.ui/META-INF/MANIFEST.MF
index 94db42dfc6..4772f6d750 100644
--- a/team/bundles/org.eclipse.jsch.ui/META-INF/MANIFEST.MF
+++ b/team/bundles/org.eclipse.jsch.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jsch.ui;singleton:=true
-Bundle-Version: 1.5.600.qualifier
+Bundle-Version: 1.5.700.qualifier
 Bundle-Activator: org.eclipse.jsch.internal.ui.JSchUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

@HannesWell
Copy link
Copy Markdown
Member Author

Submitting this early to be able to restart the I-build that just failed due to the initially mentioned source-compatibility problems.
The changed projects were compiled successfully and I don't expect an effect on tests from this change.

@HannesWell HannesWell merged commit d239749 into eclipse-platform:master May 4, 2025
9 of 12 checks passed
@HannesWell HannesWell deleted the simplify-NLS.bind-in-jsch branch May 4, 2025 22:22
subyssurendran666 added a commit to subyssurendran666/eclipse.jdt.debug that referenced this pull request May 5, 2025
Resolved the NLS.bind() issues due to the osgi

Ref: eclipse-platform/eclipse.platform#1854
subyssurendran666 added a commit to subyssurendran666/eclipse.jdt.debug that referenced this pull request May 5, 2025
Resolved the NLS.bind() issues due to the osgi

Ref: eclipse-platform/eclipse.platform#1854
SougandhS pushed a commit to subyssurendran666/eclipse.jdt.debug that referenced this pull request May 6, 2025
Resolved the NLS.bind() issues due to the osgi

Ref: eclipse-platform/eclipse.platform#1854
subyssurendran666 added a commit to subyssurendran666/eclipse.jdt.debug that referenced this pull request May 6, 2025
Resolved the NLS.bind() issues due to the osgi

Ref: eclipse-platform/eclipse.platform#1854
subyssurendran666 added a commit to subyssurendran666/eclipse.jdt.debug that referenced this pull request May 16, 2025
Resolved the NLS.bind() issues due to the osgi

Ref: eclipse-platform/eclipse.platform#1854
SougandhS pushed a commit to subyssurendran666/eclipse.jdt.debug that referenced this pull request Jun 10, 2025
Resolved the NLS.bind() issues due to the osgi

Ref: eclipse-platform/eclipse.platform#1854
SougandhS pushed a commit to eclipse-jdt/eclipse.jdt.debug that referenced this pull request Jun 11, 2025
Resolved the NLS.bind() issues due to the osgi

Ref: eclipse-platform/eclipse.platform#1854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants