Add Missing SVGs to Platform Bundles#1873
Merged
Merged
Conversation
Contributor
HeikoKlare
reviewed
May 14, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for creating the SVGs! The 16x16 icons and their references look fine to me. Some debug.ui icons are already referenced as SVGs in code even though they were not provided yet. So it definitely makes sense to have them in soon/now.
Like mentioned in eclipse-platform/eclipse.platform.ui#2970 (review), the wizard banner icons are no proper vector graphics, so we should exclude them form the change for now.
This commit adds missing SVG to Platform Bundles excluding wizard banner icons.
HeikoKlare
approved these changes
May 14, 2025
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
I've removed the wizard banner icons for the reasons mentioned in eclipse-platform/eclipse.platform.ui#2970 (review) again to make this PR ready to merge. We should have a separate look at them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds all missing SVGs to Platform Bundles except for OS-specific icons in the bundle
org.eclipse.platform/imagesfor which a deletion is proposed in this PR.All added icons were either created by me or copied if I found a duplicate with another name.
All
wizbanicons were created by using an Inkscape function to redraw the bitmap (PNG to SVG conversion). This returns pretty good results with only minimal manual work but also creates many paths resulting in SVG that are about 10x larger than other wizban SVGs. Rasterizing the SVGs "manually" by using JSVG did not yield significantly longer rasterization time in my testing. As I don't know a feasible way to create the wizban SVGs otherwise I propose to use this method.I also added available SVGs for
org.eclipse.ui.intro.universal/themeswhich were forgotten before but already existed in the images repository.All missing SVGs are documented in this issue.