Add all missing SVGs for icons in Eclipse Platform#1882
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for contributing all these icons, @Michael5601! It's really nice to see almost every image in platform now being replaced with SVGs. In particular the wizard banner icons have been quite some effort for you to create.
This all looks fine to me. @BeckerWdf can you please have an additional look. In particular since Michael has created the wizard banner icons from scratch and I would like to be sure that everything is consistent with the PNGs we had before and with the requirements we may have to SVGs. I compared all of them, and to me they look fine.
When scanning through the projects in this repository, I found two places where PNGs are still references that have meanwhile been replaced with SVGs, so we could update them as well:
PreferencePageContainerDialogcontains to image descriptors referencing PNGs- The plugin.xml of
org.eclipse.ui.intro.quicklinks.examplesreferences two wizard banners in Platform UI, for which meanwhile SVGs have been provided
|
@Michael5601 seeing your latest commit, please note that the restore_welcome.svg has already been added: |
Thanks, I knew I remembered something :D I will remove it. |
This commit adds missing SVGs for all wizban icons in Eclipse Platform. Furthermore SVGs for icons in the bundles `org.eclipse.unittest.ui`, `org.eclipse.tips.ui` and `org.eclipse.tips.ide` are added by copying from other bundles or creating from scratch. The examples in .exsd files are adjusted.
This PR adds missing SVGs for all wizban icons in Eclipse Platform. Furthermore SVGs for icons in the bundles
org.eclipse.unittest.ui,org.eclipse.tips.uiandorg.eclipse.tips.idewere added by copying from other bundles or creating from scratch.