Skip to content

Add all missing SVGs for icons in Eclipse Platform#1882

Merged
HeikoKlare merged 2 commits into
eclipse-platform:masterfrom
Michael5601:Missing-Wizban-SVGs
Jun 6, 2025
Merged

Add all missing SVGs for icons in Eclipse Platform#1882
HeikoKlare merged 2 commits into
eclipse-platform:masterfrom
Michael5601:Missing-Wizban-SVGs

Conversation

@Michael5601
Copy link
Copy Markdown
Contributor

@Michael5601 Michael5601 commented May 19, 2025

This PR adds missing SVGs for all wizban icons in Eclipse Platform. Furthermore SVGs for icons in the bundles org.eclipse.unittest.ui, org.eclipse.tips.ui and org.eclipse.tips.ide were added by copying from other bundles or creating from scratch.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

Test Results

 1 764 files  ±0   1 764 suites  ±0   1h 34m 5s ⏱️ + 1m 41s
 4 381 tests ±0   4 357 ✅ ±0   24 💤 ±0  0 ❌ ±0 
13 143 runs  ±0  12 976 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 096d17b. ± Comparison against base commit ed523bf.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare added this to the 4.37 M1 milestone May 20, 2025
@Michael5601 Michael5601 changed the title Add SVGs for wizban icons in org.eclipse.debug.ui Add all missing SVGs for wizban icons in Eclipse Platform May 26, 2025
@Michael5601 Michael5601 changed the title Add all missing SVGs for wizban icons in Eclipse Platform Add all missing SVGs for icons in Eclipse Platform May 27, 2025
@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

eclipse-platform-bot commented May 27, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF
debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
ua/org.eclipse.ui.intro/META-INF/MANIFEST.MF
ua/org.eclipse.ui.intro/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 696b4cdca319254e53bb5adab2a4019bce1bb603 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 6 Jun 2025 10:07:56 +0000
Subject: [PATCH] Version bump(s) for 4.37 stream


diff --git a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
index 9474268cec..82916aa04e 100644
--- a/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.debug.ui; singleton:=true
-Bundle-Version: 3.18.800.qualifier
+Bundle-Version: 3.18.900.qualifier
 Bundle-Activator: org.eclipse.debug.internal.ui.DebugUIPlugin
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
diff --git a/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF b/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF
index b0aaba767b..45dfb974e8 100644
--- a/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.ui.externaltools/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.externaltools; singleton:=true
-Bundle-Version: 3.6.600.qualifier
+Bundle-Version: 3.6.700.qualifier
 Bundle-Activator: org.eclipse.ui.externaltools.internal.model.ExternalToolsPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
diff --git a/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
index 484a5f4c54..cc0097a372 100644
--- a/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.unittest.ui
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.unittest.ui;singleton:=true
-Bundle-Version: 1.1.600.qualifier
+Bundle-Version: 1.1.700.qualifier
 Bundle-Activator: org.eclipse.unittest.internal.UnitTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/ua/org.eclipse.ui.intro/META-INF/MANIFEST.MF b/ua/org.eclipse.ui.intro/META-INF/MANIFEST.MF
index 21bebbc014..0937ae5c08 100644
--- a/ua/org.eclipse.ui.intro/META-INF/MANIFEST.MF
+++ b/ua/org.eclipse.ui.intro/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %plugin_name
 Bundle-SymbolicName: org.eclipse.ui.intro; singleton:=true
-Bundle-Version: 3.7.600.qualifier
+Bundle-Version: 3.7.700.qualifier
 Bundle-Activator: org.eclipse.ui.internal.intro.impl.IntroPlugin
 Bundle-Vendor: %provider_name
 Bundle-Localization: plugin
diff --git a/ua/org.eclipse.ui.intro/pom.xml b/ua/org.eclipse.ui.intro/pom.xml
index e9906cda14..4c7bc95578 100644
--- a/ua/org.eclipse.ui.intro/pom.xml
+++ b/ua/org.eclipse.ui.intro/pom.xml
@@ -18,6 +18,6 @@
   </parent>
   <groupId>org.eclipse.platform</groupId>
   <artifactId>org.eclipse.ui.intro</artifactId>
-  <version>3.7.600-SNAPSHOT</version>
+  <version>3.7.700-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
 </project>
-- 
2.49.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Copy Markdown
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing all these icons, @Michael5601! It's really nice to see almost every image in platform now being replaced with SVGs. In particular the wizard banner icons have been quite some effort for you to create.

This all looks fine to me. @BeckerWdf can you please have an additional look. In particular since Michael has created the wizard banner icons from scratch and I would like to be sure that everything is consistent with the PNGs we had before and with the requirements we may have to SVGs. I compared all of them, and to me they look fine.

When scanning through the projects in this repository, I found two places where PNGs are still references that have meanwhile been replaced with SVGs, so we could update them as well:

  • PreferencePageContainerDialog contains to image descriptors referencing PNGs
  • The plugin.xml of org.eclipse.ui.intro.quicklinks.examples references two wizard banners in Platform UI, for which meanwhile SVGs have been provided

Comment thread ua/org.eclipse.ui.intro.quicklinks/schema/quicklinks.exsd
Comment thread ua/org.eclipse.ui.intro.quicklinks/schema/quicklinks.exsd
Comment thread ua/org.eclipse.ui.intro/schema/configExtension.exsd
@HeikoKlare
Copy link
Copy Markdown
Contributor

@Michael5601 seeing your latest commit, please note that the restore_welcome.svg has already been added:

@Michael5601
Copy link
Copy Markdown
Contributor Author

@Michael5601 seeing your latest commit, please note that the restore_welcome.svg has already been added:

Thanks, I knew I remembered something :D I will remove it.

Michael Bangas and others added 2 commits June 6, 2025 14:16
This commit adds missing SVGs for all wizban icons in Eclipse Platform. Furthermore SVGs for icons in the bundles `org.eclipse.unittest.ui`, `org.eclipse.tips.ui` and `org.eclipse.tips.ide` are added by copying from other bundles or creating from scratch. The examples in .exsd files are adjusted.
@HeikoKlare HeikoKlare merged commit a518c62 into eclipse-platform:master Jun 6, 2025
18 checks passed
@Michael5601 Michael5601 deleted the Missing-Wizban-SVGs branch June 16, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants