Skip to content

[Debug] Add F2 shortcut for renaming breakpoints#2092

Merged
vogella merged 1 commit intoeclipse-platform:masterfrom
SougandhS:ShortcutBPLabel
Jul 31, 2025
Merged

[Debug] Add F2 shortcut for renaming breakpoints#2092
vogella merged 1 commit intoeclipse-platform:masterfrom
SougandhS:ShortcutBPLabel

Conversation

@SougandhS
Copy link
Copy Markdown
Contributor

Improve usability of custom breakpoint label by mapping the F2 key to rename breakpoints, aligning with the standard convention for renaming items across platforms.

based on : #1803 (comment)

BPShortCut.mp4

@SougandhS
Copy link
Copy Markdown
Contributor Author

Hi @vogella,
made the changes as suggested 👍

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 30, 2025

Test Results

 1 947 files  ±0   1 947 suites  ±0   1h 29m 59s ⏱️ - 15m 8s
 4 720 tests ±0   4 696 ✅ ±0   24 💤 ±0  0 ❌ ±0 
14 160 runs  ±0  13 993 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit a459469. ± Comparison against base commit 11a1333.

♻️ This comment has been updated with latest results.

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Jul 30, 2025

Tested and work very well, thanks.

Would it be possible to pre-select the existing name like F2 does for file?

image

In most cases I assume I don't want to change the name but create a new one and if the text is pre-selected I can simply start typing and override the existing string without deleting or selecting it myself.

@SougandhS
Copy link
Copy Markdown
Contributor Author

Would it be possible to pre-select the existing name like F2 does for file?

but it is already pre-selected

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Jul 30, 2025

Would it be possible to pre-select the existing name like F2 does for file?

but it is already pre-selected

Not for me, if I press F2 the text is not pre-selected (testing under Ubuntu)

Bildschirmaufzeichnung.vom.2025-07-30.09-28-04.webm

@SougandhS
Copy link
Copy Markdown
Contributor Author

Not for me, if I press F2 the text is not pre-selected (testing under Ubuntu)

Strange, for Mac it is working

BPShortCut.mp4

I'll check whats the issue is 👍

@SougandhS
Copy link
Copy Markdown
Contributor Author

SougandhS commented Jul 30, 2025

Not for me, if I press F2 the text is not pre-selected (testing under Ubuntu)

Added an explicit org.eclipse.swt.widgets.Text.selectAll() that should fix 👍

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Jul 30, 2025

Not for me, if I press F2 the text is not pre-selected (testing under Ubuntu)

Added an explicit org.eclipse.swt.widgets.Text.selectAll() that should fix 👍

Thanks, looks good. Planning to merge once the verification build is done.

Improve usability of custom breakpoint label by mapping the F2 key to
rename breakpoints, aligning with the standard convention for renaming
items across platforms and select all texts in current breakpoint label
on opening the inline editor
@vogella
Copy link
Copy Markdown
Contributor

vogella commented Jul 31, 2025

Jenkins Build failure looks unrelated: 05:03:14.963 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:3.4.0:war (default-war) on project infocenter-app: Error assembling WAR: Problem creating war: Execution exception: Java heap space -> [Help 1]

Merging, thanks @SougandhS

@vogella vogella merged commit 6810983 into eclipse-platform:master Jul 31, 2025
16 of 18 checks passed
@SougandhS
Copy link
Copy Markdown
Contributor Author

Thank you @vogella

@vogella
Copy link
Copy Markdown
Contributor

vogella commented Jul 31, 2025

Thank you @vogella

Thanks for this super nice enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants