Skip to content

Test Harness: Session Tests: List felix.scr dependencies explicitly#2165

Merged
sratz merged 1 commit intoeclipse-platform:masterfrom
sratz:testharness-dependencies
Sep 18, 2025
Merged

Test Harness: Session Tests: List felix.scr dependencies explicitly#2165
sratz merged 1 commit intoeclipse-platform:masterfrom
sratz:testharness-dependencies

Conversation

@sratz
Copy link
Copy Markdown
Member

@sratz sratz commented Sep 17, 2025

  • We don't need the optional ones

  • We should not install org.eclipse.osgi again, as this is already set as the 'osgi.framework' in the config.ini

It's easier to just list the few dependencies we really want explicitly.

Another follow-up on #2162.
Addresses eclipse-equinox/equinox#1146.

* We don't need the optional ones

* We should not install org.eclipse.osgi again, as this is already set
  as the 'osgi.framework' in the config.ini

It's easier to just list the few dependencies we really want explicitly.
@sratz sratz force-pushed the testharness-dependencies branch from 984e3e9 to fb150ba Compare September 17, 2025 22:00
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

 1 947 files  + 27   1 947 suites  +27   1h 52m 44s ⏱️ + 3m 35s
 4 720 tests ±  0   4 696 ✅ +  2   24 💤 ±0  0 ❌  - 2 
14 160 runs  +153  13 993 ✅ +155  167 💤 ±0  0 ❌  - 2 

Results for commit fb150ba. ± Comparison against base commit 3f36b28.

@HeikoKlare
Copy link
Copy Markdown
Contributor

Please note that ConfigurationSessionTestSuite is actually outdated (I should probably mark it deprecated) and should be removed as soon as possible to avoid the duplicate maintenance efforts. The only remaining consumer is Equinox, for which I have implemented the according migration started with eclipse-equinox/equinox#654, which is still pending.

@sratz
Copy link
Copy Markdown
Member Author

sratz commented Sep 18, 2025

Please note that ConfigurationSessionTestSuite is actually outdated (I should probably mark it deprecated) and should be removed as soon as possible to avoid the duplicate maintenance efforts. The only remaining consumer is Equinox, for which I have implemented the according migration started with eclipse-equinox/equinox#654, which is still pending.

Ah, thanks @HeikoKlare! That explains why I missed adjusting one of them (besides not looking thoroughly enough) in my initial change to include SCR.

@sratz sratz merged commit 00bf88d into eclipse-platform:master Sep 18, 2025
18 checks passed
@sratz sratz deleted the testharness-dependencies branch September 18, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants