Enhance stack trace information for rule conflicts in BuildManager#2279
Conversation
e5b4927 to
b906eae
Compare
Test Results 54 files 54 suites 37m 54s ⏱️ Results for commit 985256c. ♻️ This comment has been updated with latest results. |
f754b17 to
02578f4
Compare
02578f4 to
d4e060e
Compare
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
32c5cdf to
a3346dd
Compare
|
Old (without the patch what the JobManager throws raw): Begin-rule conflict: End-rule conflict:
End-rule conflict:
|
Fixes eclipse-platform#2278 When a builder attempts to begin or end a scheduling rule that doesn't match the outer scope rule, the error message now includes: - Builder name and label - Builder class name - Plugin ID - Project name - The conflicting rule This makes it much easier to identify which builder is causing the rule mismatch, especially in complex build scenarios with multiple builders. The enhancement catches IllegalArgumentException at the point where beginRule() and endRule() are called in BuildManager.basicBuild() and wraps it with detailed context before re-throwing.
a3346dd to
985256c
Compare
Fixes #2278
When a builder attempts to begin or end a scheduling rule that doesn't match the outer scope rule, the error message now includes:
This makes it much easier to identify which builder is causing the rule mismatch, especially in complex build scenarios with multiple builders.
The enhancement catches IllegalArgumentException at the point where beginRule() and endRule() are called in BuildManager.basicBuild() and wraps it with detailed context before re-throwing.