Add preference page for console icon update#2435
Add preference page for console icon update#2435iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
Conversation
|
It seems kind of "lost at the end" of the preferences. Personally I think it would be better next to the "Pin..." preference. |
Test Results1 318 files - 659 1 318 suites - 659 1h 1m 4s ⏱️ - 31m 10s Results for commit 19c55cd. ± Comparison against base commit 56e8969. This pull request skips 25 tests.♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
Adds a user preference to enable/disable dynamic updating of the Console view icon based on the currently active console page (Fixes #2434).
Changes:
- Add a new Console preference key and default value for icon auto-update.
- Add a checkbox to the Console preference page to control icon auto-update.
- Gate ConsoleView icon updates based on the new preference.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleView.java | Checks the new preference to decide whether to use the dynamic per-console icon or the default icon. |
| debug/org.eclipse.ui.console/src/org/eclipse/ui/internal/console/ConsoleUIPreferenceInitializer.java | Sets the default value for the new preference (enabled). |
| debug/org.eclipse.ui.console/src/org/eclipse/ui/console/IConsoleConstants.java | Introduces the new preference constant in the public constants interface. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.properties | Adds the UI label string for the new checkbox. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.java | Adds the corresponding NLS field for the new message key. |
| debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/ConsolePreferencePage.java | Adds a new BooleanFieldEditor for the icon auto-update preference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iloveeclipse
left a comment
There was a problem hiding this comment.
I will push updated commit in a moment
This commit adds a preference option in console preference for enable/disable dynamic console update based on active console page Fixes: eclipse-platform#2434 Co-authored-by: Andrey Loskutov <loskutov@gmx.de>

This commit adds a preference option in console preference for enable/disable dynamic console update based on active console page
Fixes : #2434