Skip to content

Use line ranges in compare editor by default#2565

Merged
iloveeclipse merged 1 commit into
eclipse-platform:masterfrom
iloveeclipse:issue_3776_line
Mar 13, 2026
Merged

Use line ranges in compare editor by default#2565
iloveeclipse merged 1 commit into
eclipse-platform:masterfrom
iloveeclipse:issue_3776_line

Conversation

@iloveeclipse

Copy link
Copy Markdown
Member

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

    51 files   -   3      51 suites   - 3   35m 39s ⏱️ - 1m 26s
 4 546 tests ±  0   4 522 ✅ ±  0   23 💤 ±0  1 ❌ ±0 
12 081 runs   - 153  11 921 ✅  - 153  159 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 021e155. ± Comparison against base commit 2776d6f.

@iloveeclipse

Copy link
Copy Markdown
Member Author
artifacts/test-results-ubuntu-latest/resources/tests/org.eclipse.core.tests.resources/target/surefire-reports/TEST-org.eclipse.core.tests.resources.AutomatedResourceTests.xml [took 0s]
project 'P/a06e67f9e71e00111d63b712e335a2fb' is not expected to have nature: org.eclipse.core.tests.resources.earthNature
org.opentest4j.AssertionFailedError: project 'P/a06e67f9e71e00111d63b712e335a2fb' is not expected to have nature: org.eclipse.core.tests.resources.earthNature
	at org.eclipse.core.tests.resources.NatureTest.assertDoesNotHaveNature(NatureTest.java:125)
	at org.eclipse.core.tests.resources.NatureTest.testBug297871(NatureTest.java:311)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)

!ENTRY org.eclipse.core.tests.resources 1 0 2026-03-13 14:21:49.577
!MESSAGE [NatureTest.testBug297871] setUp

!ENTRY org.eclipse.core.resources 2 2 2026-03-13 14:21:49.582
!MESSAGE Save operation warnings.
!SUBENTRY 1 org.eclipse.core.resources 2 234 2026-03-13 14:21:49.582
!MESSAGE The project description file (.project) for 'a06e67f9e71e00111d63b712e335a2fb' was missing.  This file contains important information about the project.  A new project description file has been created, but some information about the project may have been lost.

!ENTRY org.eclipse.core.tests.resources 1 0 2026-03-13 14:21:49.586
!MESSAGE [NatureTest.testBug297871] tearDown 

Test failure above is unrelated, only on Linux/Ubuntu machine, so must be unstable test.

@iloveeclipse iloveeclipse merged commit 8a99f8c into eclipse-platform:master Mar 13, 2026
20 of 22 checks passed
@iloveeclipse iloveeclipse deleted the issue_3776_line branch March 13, 2026 17:39
@HannesWell

Copy link
Copy Markdown
Member

While I find the new default visually appealing, it has one major functional draw-back:
For local changes the 'move'/undo buttons are not available:

Single line connection:
Image
'Range' connection:
Image

Without that the diff-view loses a tool, that at least I consider very important.
I assume these buttons can be added even for 'Range' connections, but until then I'm against making it the default.

@HannesWell

Copy link
Copy Markdown
Member

For local changes the 'move'/undo buttons are not available:

@iloveeclipse what's the status on this issue?
Is there any plan to add those buttons or should this be reverted instead?

@iloveeclipse

Copy link
Copy Markdown
Member Author

For local changes the 'move'/undo buttons are not available:

@iloveeclipse what's the status on this issue? Is there any plan to add those buttons or should this be reverted instead?

No revert is needed, there are buttons on the top of the compare editor for same operation, and it is the preference that ome can change. I do not plan to add extra buttons on lines.

@HannesWell

HannesWell commented Mar 17, 2026

Copy link
Copy Markdown
Member

Using the buttons in the toolbar is not really a satisfying alternative, at least for me.
One has to move the mouse much more, which becomes really annoying, especially on large diffs.
But maybe that's just my opinion...

Sure I can revert that in each workspace or configure my Oomph setup to do it, but I'm not sure if everyone who's not happy with the new default wants to do that.

@akurtakov

Copy link
Copy Markdown
Member

I was hit by this problem too. The buttons in the top are context sensitive so one can very easily have the wrong effect if haven't clicked in the right place before that. I second the request to add the buttons in the diff view back.

@merks

merks commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

I'm generally concerned about changing defaults and that concern grows when even two committers are not happy with the new default. It makes me concerned that maybe a large number of end-users will also not be happy, and that they will not read the N&N to find out they can change it back. The reaction might be, "Oh, something new and improved that I don't like!" I'm not sure we have a way to reconcile such a thing? I wonder how hard it would be to add the button? (Personally I generally use the toolbar buttons, but I also very often press the wrong one and it's super annoying.)

@fedejeanne

Copy link
Copy Markdown
Member

I also noticed this loss of functionality just recently and found it unpleasant and since there is no preference in UI (Window > Preferences > ...) other "regular" users will be hit by it too.

I would like to see this change reverted.

@iloveeclipse

Copy link
Copy Markdown
Member Author

I also noticed this loss of functionality

2222ff6 / #2583 was supposed to fix that.

and since there is no preference in UI

Sure there is a preference in UI:
image

@fedejeanne

Copy link
Copy Markdown
Member

Thank you very much for the hints! I totally missed them before :-\

I withdraw then my comment...

I would like to see this change reverted.

👍

@merks

merks commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

I still keep thinking it might be nice to paint little buttons too. Maybe circular ones. But this only seems to matter for large changes.

@iloveeclipse

Copy link
Copy Markdown
Member Author

I still keep thinking it might be nice to paint little buttons too. Maybe circular ones

Or maybe just "dots" with darker color. COntributions are welcome :-)

@fedejeanne

Copy link
Copy Markdown
Member

I'm quite happy with the current arrows but don't stop innovation on my account (I am a self-proclaimed "dinosaur" when it comes to UI/UX improvements 😅 )

HannesWell added a commit to HannesWell/eclipse.platform that referenced this pull request May 1, 2026
When comparing diffs with five or more lines, show the 'move'-button
markers even when using range connections in order to assist the user in
finding the move buttons, which only appear when hovering over them.
For smaller diffs the marker is not shown to clutter the UI less as the
markers are then relatively easy to find in the middle of the range.

Follow-up on
- eclipse-platform#2565
@HannesWell

Copy link
Copy Markdown
Member

I still keep thinking it might be nice to paint little buttons too. Maybe circular ones. But this only seems to matter for large changes.

For larger diffs the move buttons are indeed hard to find. I created a PR to show the markers for larger diffs:

HannesWell added a commit that referenced this pull request May 4, 2026
When comparing diffs with five or more lines, show the 'move'-button
markers even when using range connections in order to assist the user in
finding the move buttons, which only appear when hovering over them.
For smaller diffs the marker is not shown to clutter the UI less as the
markers are then relatively easy to find in the middle of the range.

Follow-up on
- #2565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve compare defaults

5 participants