Use line ranges in compare editor by default#2565
Use line ranges in compare editor by default#2565iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
Conversation
Test Results 51 files - 3 51 suites - 3 35m 39s ⏱️ - 1m 26s For more details on these failures, see this check. Results for commit 021e155. ± Comparison against base commit 2776d6f. |
Test failure above is unrelated, only on Linux/Ubuntu machine, so must be unstable test. |
@iloveeclipse what's the status on this issue? |
No revert is needed, there are buttons on the top of the compare editor for same operation, and it is the preference that ome can change. I do not plan to add extra buttons on lines. |
|
Using the buttons in the toolbar is not really a satisfying alternative, at least for me. Sure I can revert that in each workspace or configure my Oomph setup to do it, but I'm not sure if everyone who's not happy with the new default wants to do that. |
|
I was hit by this problem too. The buttons in the top are context sensitive so one can very easily have the wrong effect if haven't clicked in the right place before that. I second the request to add the buttons in the diff view back. |
|
I'm generally concerned about changing defaults and that concern grows when even two committers are not happy with the new default. It makes me concerned that maybe a large number of end-users will also not be happy, and that they will not read the N&N to find out they can change it back. The reaction might be, "Oh, something new and improved that I don't like!" I'm not sure we have a way to reconcile such a thing? I wonder how hard it would be to add the button? (Personally I generally use the toolbar buttons, but I also very often press the wrong one and it's super annoying.) |
|
I also noticed this loss of functionality just recently and found it unpleasant and since there is no preference in UI ( I would like to see this change reverted. |
|
Thank you very much for the hints! I totally missed them before :-\ I withdraw then my comment...
👍 |
|
I still keep thinking it might be nice to paint little buttons too. Maybe circular ones. But this only seems to matter for large changes. |
Or maybe just "dots" with darker color. COntributions are welcome :-) |
|
I'm quite happy with the current arrows but don't stop innovation on my account (I am a self-proclaimed "dinosaur" when it comes to UI/UX improvements 😅 ) |



See eclipse-platform/eclipse.platform.ui#3776