Collapse inline Status allocations to ILog.of(Class) log sites#2628
Merged
Conversation
Contributor
Contributor
Author
|
Build failure looks unrelated: Error: Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:5.0.3-SNAPSHOT:test (default-test) on project org.eclipse.core.tests.resources.saveparticipant1: No tests found -> [Help 1] |
Replace Plugin.getDefault().getLog().log(new Status(...)) with ILog.of(MyClass.class).error(...) / .log(status) in non-activator classes to drop the activator round-trip and the Status allocation where applicable. Only touches sites where the class and the previously-used activator live in the same bundle, so log attribution is unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vogella
force-pushed
the
modernize-plugin-getlog
branch
from
ccff05f to
479595c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
Plugin.getDefault().getLog().log(new Status(...))withILog.of(MyClass.class).error(...)/.log(status)in non-activator classes, dropping the activator round-trip and theStatusallocation where applicable. Follow-up to the counterpart cleanup in eclipse-platform/eclipse.platform.ui.Scope of this PR is intentionally narrow: only sites where the class and the previously-used activator live in the same bundle, so log attribution is unchanged. Remaining sites (activator static
log()helpers, utilityLogclasses, cross-bundle attribution, etc.) are deferred to follow-up PRs so each category can be reviewed on its own merits.Files touched (9):
debug/org.eclipse.debug.examples.core—PDADebugTargetterminal/org.eclipse.terminal.connector.local—LocalLauncherDelegateterminal/org.eclipse.terminal.view.ui—PreferencePage,TerminalsView,AbstractAction,NewTerminalViewAction,AbstractTriggerCommandHandler,InputStreamMonitor,OutputStreamMonitorContext: vogellacompany/tasks#1837
Test plan
mvn clean verify -Pbuild-individual-bundleson each affected bundle.logwith the expected bundle id