Skip to content

Fix random failing testBug546710_ConsoleCreationRaceCondition #596#2639

Draft
fedejeanne wants to merge 1 commit intoeclipse-platform:masterfrom
fedejeanne:copilot/fix-random-failing-console-tests-2
Draft

Fix random failing testBug546710_ConsoleCreationRaceCondition #596#2639
fedejeanne wants to merge 1 commit intoeclipse-platform:masterfrom
fedejeanne:copilot/fix-random-failing-console-tests-2

Conversation

@fedejeanne
Copy link
Copy Markdown
Member

  • Cancel all instances of ConsoleCreationJob for a given process when removing a launch.
  • Skip the creation of a console for a launch that has been canceled already.
  • Adapt assertion in test (it was checking the wrong console)

Fixes #596

…-platform#596

- Cancel all instances of ConsoleCreationJob for a given process when
removing a launch.
- Skip the creation of a console for a launch that has been canceled
already.
- Adapt assertion in test (it was checking the wrong console)

Fixes eclipse-platform#596

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   36m 26s ⏱️ - 1m 12s
 4 558 tests ±0   4 536 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 270 runs  ±0  12 114 ✅ ±0  156 💤 ±0  0 ❌ ±0 

Results for commit 44d012c. ± Comparison against base commit afeaa45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Random failing ProcessConsoleManagerTests.testBug546710_ConsoleCreationRaceCondition

1 participant