Skip to content

Clean Code for runtime/bundles/org.eclipse.e4.core.di.extensions.supplier#2711

Merged
akurtakov merged 2 commits into
masterfrom
clean-code/runtime/bundles/org.eclipse.e4.core.di.extensions.supplier
Jun 5, 2026
Merged

Clean Code for runtime/bundles/org.eclipse.e4.core.di.extensions.supplier#2711
akurtakov merged 2 commits into
masterfrom
clean-code/runtime/bundles/org.eclipse.e4.core.di.extensions.supplier

Conversation

@eclipse-platform-bot

Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-platform-bot

Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.e4.core.di.extensions.supplier/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From e5047399e53c560f0fb8f506f86d3666185123c5 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Fri, 5 Jun 2026 04:49:50 +0000
Subject: [PATCH] Version bump(s) for 4.41 stream


diff --git a/runtime/bundles/org.eclipse.e4.core.di.extensions.supplier/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.e4.core.di.extensions.supplier/META-INF/MANIFEST.MF
index a29668a612..404106b17f 100644
--- a/runtime/bundles/org.eclipse.e4.core.di.extensions.supplier/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.e4.core.di.extensions.supplier/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-Vendor: %Bundle-Vendor
 Bundle-SymbolicName: org.eclipse.e4.core.di.extensions.supplier
-Bundle-Version: 0.17.1100.qualifier
+Bundle-Version: 0.17.1200.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Capability: osgi.extender;
   filter:="(&(osgi.extender=osgi.component)(version>=1.3)(!(version>=2.0)))"
-- 
2.54.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   34m 42s ⏱️ - 2m 16s
 4 671 tests ±0   4 649 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 907 runs  ±0  11 754 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit ea42300. ± Comparison against base commit a0b74bc.

@akurtakov akurtakov merged commit 95b50e5 into master Jun 5, 2026
18 checks passed
@akurtakov akurtakov deleted the clean-code/runtime/bundles/org.eclipse.e4.core.di.extensions.supplier branch June 5, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants