Skip to content

Switch to Platform.getDebugBoolean(String) where appropriate#2785

Merged
ptziegler merged 1 commit into
eclipse-platform:masterfrom
ptziegler:use-get-debug-boolean
Jul 10, 2026
Merged

Switch to Platform.getDebugBoolean(String) where appropriate#2785
ptziegler merged 1 commit into
eclipse-platform:masterfrom
ptziegler:use-get-debug-boolean

Conversation

@ptziegler

Copy link
Copy Markdown
Contributor

With 3b76d20, a convenience method getDebugBoolean(String) was added, which returns true if the given tracing option is enabled. Using this method avoids a lot of the boilerplate code that comes with using getDebugOption(String) and which usually looks something like:

"true".equals(Platform.getDebugOption("..."))

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   57m 54s ⏱️ + 1m 21s
 4 687 tests ±0   4 665 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 955 runs  ±0  11 802 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 8d0e0b5. ± Comparison against base commit c999058.

♻️ This comment has been updated with latest results.

@vogella

vogella commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

LGTM

@ptziegler ptziegler force-pushed the use-get-debug-boolean branch from ab412d7 to 443331b Compare July 3, 2026 10:07
With 3b76d20, a convenience method
`getDebugBoolean(String)` was added, which returns `true` if the given
tracing option is enabled. Using this method avoids a lot of the
boilerplate code that comes with using `getDebugOption(String)` and
which usually looks something like:

`"true".equals(Platform.getDebugOption("..."))`
@ptziegler ptziegler force-pushed the use-get-debug-boolean branch from 443331b to 8d0e0b5 Compare July 10, 2026 08:28
@ptziegler ptziegler merged commit 2743386 into eclipse-platform:master Jul 10, 2026
18 checks passed
@ptziegler

Copy link
Copy Markdown
Contributor Author

@vogella Thank you checking this PR! 🎉

@ptziegler ptziegler deleted the use-get-debug-boolean branch July 10, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants