Skip to content

Commit cb691e8

Browse files
authored
Merge pull request #266 from Mailaender/localized-views-logger
Don't log an error when a view can't be found by pattern
2 parents f508ced + b5c1efe commit cb691e8

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

  • modules/rap/bundles/runtime/tesla/org.eclipse.rcptt.tesla.swt.rap/src/org/eclipse/rcptt/tesla/internal/ui/player
  • runtime/tesla/org.eclipse.rcptt.tesla.swt/src/org/eclipse/rcptt/tesla/internal/ui/player

modules/rap/bundles/runtime/tesla/org.eclipse.rcptt.tesla.swt.rap/src/org/eclipse/rcptt/tesla/internal/ui/player/SWTUIPlayer.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -740,14 +740,11 @@ public SWTUIElement selectView(PlayerSelectionFilter f) {
740740
currIdx++;
741741
}
742742
} catch (Exception e) {
743-
// Skip brokeb parts.
743+
// Skip broken parts.
744744
TeslaCore.log(e);
745745
}
746746
}
747747

748-
TeslaCore.log("Can not find view by pattern \"" + pattern
749-
+ "\". Activating views...");
750-
751748
// Not found, lets go with resolve of view parts, it will initialize
752749
// titles.
753750
currIdx = 0;
@@ -766,6 +763,7 @@ public SWTUIElement selectView(PlayerSelectionFilter f) {
766763
currIdx++;
767764
}
768765
}
766+
TeslaCore.log("Can not find view by pattern \"" + pattern + "\".");
769767
return null;
770768
}
771769

runtime/tesla/org.eclipse.rcptt.tesla.swt/src/org/eclipse/rcptt/tesla/internal/ui/player/SWTUIPlayer.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -703,13 +703,11 @@ public SWTUIElement selectView(PlayerSelectionFilter f) {
703703
currIdx++;
704704
}
705705
} catch (Exception e) {
706-
// Skip brokeb parts.
706+
// Skip broken parts.
707707
TeslaCore.log(e);
708708
}
709709
}
710710

711-
TeslaCore.log("Can not find view by pattern \"" + pattern + "\". Activating views...");
712-
713711
// Not found, lets go with resolve of view parts, it will initialize
714712
// titles.
715713
currIdx = 0;
@@ -727,6 +725,7 @@ public SWTUIElement selectView(PlayerSelectionFilter f) {
727725
currIdx++;
728726
}
729727
}
728+
TeslaCore.log("Can not find view by pattern \"" + pattern + "\".");
730729
return null;
731730
}
732731

0 commit comments

Comments
 (0)