Remove redundant buildUrl Maven property declarations#317
Merged
Conversation
…xml files All child pom.xml files inherit buildUrl from the root releng/pom.xml. Removed redundant redefinitions from: - releng/ide/pom.xml - releng/runner/pom.xml - releng/rcptt/pom.xml - releng/rap/pom.xml - releng/mirroring/pom.xml Agent-Logs-Url: https://github.com/eclipse-rcptt/org.eclipse.rcptt/sessions/33c6b08a-d396-4af8-962b-1a3ed119c8ba Co-authored-by: basilevs <650857+basilevs@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove redundant buildUrl Maven property declarations
Remove redundant buildUrl Maven property declarations
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five child
pom.xmlfiles redeclarebuildUrldespite inheriting it fromreleng/pom.xml. These redefinitions are redundant and risk overriding a correct value passed via command line (e.g., on Windows).<buildUrl>fromreleng/ide/pom.xml,releng/runner/pom.xml,releng/rcptt/pom.xml,releng/rap/pom.xml, andreleng/mirroring/pom.xmlreleng/mirroring/pom.xmlhad its entire<properties>block removed sincebuildUrlwas its only propertyreleng/rap/pom.xmlnotably usedfile:${user.dir}(missing/) vs the parent'sfile:/${user.dir}— now consistently inherits the correct formThe canonical definition remains solely in
releng/pom.xml. All removed declarations are reachable via parent chains: