Fix pessimizing-move warnings in future/promise tests

GCC 14's -Werror=pessimizing-move detects std::move() on return values,
which prevents copy elision and forces unnecessary move operations.

Solution: remove std::move() from temporary return values and let the
compiler apply copy elision optimization.

Applied to 7 instances across:
- base_interruptible_future_test.cpp (4 instances)
- interruptible_shared_future_test.cpp (2 instances)
- task_result_test.cpp (1 instance)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Signed-off-by: Leonardo Rossetti <lrossett@redhat.com>

Author: 2 people

score/concurrency/future/base_interruptible_future_test.cpp

@@ -316,7 +316,7 @@ TYPED_TEST(BaseInterruptibleFutureTest, WaitReturnsOnlyAfterValueWasSet)
 
     BaseInterruptibleFutureTest<TypeParam>::SetPromise(this->promise_);
 
-    auto expected = std::move(async_future.get());
+    auto expected = async_future.get();
     EXPECT_TRUE(expected.has_value());
 }
 
@@ -351,7 +351,7 @@ TYPED_TEST(BaseInterruptibleFutureTest, WaitForReturnsTimeoutErrorWhenValueWasNo
         return this->future_->WaitFor(stop_token, TIMEOUT);
     });
 
-    auto expected = std::move(async_future.get());
+    auto expected = async_future.get();
     ASSERT_FALSE(expected.has_value());
     EXPECT_EQ(expected.error(), Error::kTimeout);
 }
@@ -388,7 +388,7 @@ TYPED_TEST(BaseInterruptibleFutureTest, WaitForReturnsWhenValueIsSet)
     });
     BaseInterruptibleFutureTest<TypeParam>::SetPromise(this->promise_);
 
-    auto expected = std::move(async_future.get());
+    auto expected = async_future.get();
     EXPECT_TRUE(expected.has_value());
 }
 
@@ -400,7 +400,7 @@ TYPED_TEST(BaseInterruptibleFutureTest, WaitUntilReturnsTimeoutErrorWhenValueWas
         return this->future_->WaitUntil(stop_token, std::chrono::steady_clock::now() + TIMEOUT);
     });
 
-    auto expected = std::move(async_future.get());
+    auto expected = async_future.get();
     ASSERT_FALSE(expected.has_value());
     EXPECT_EQ(expected.error(), Error::kTimeout);
 }

score/concurrency/future/interruptible_shared_future_test.cpp

@@ -349,7 +349,7 @@ TYPED_TEST(InterruptibleSharedFutureTest, GetReturnsOnlyAfterValueWasSet)
 
     InterruptibleSharedFutureTest<TypeParam>::SetPromise(this->promise_);
 
-    auto expected = std::move(async_future.get());
+    auto expected = async_future.get();
     InterruptibleSharedFutureTest<TypeParam>::ExpectCorrectValue(expected);
 }
 
@@ -358,7 +358,7 @@ TYPED_TEST(InterruptibleSharedFutureTest, GetReturnsErrorWhenSet)
     this->promise_.SetError(Error::kFutureAlreadyRetrieved);
 
     score::cpp::stop_token stop_token{};
-    auto expected = std::move(this->future_.Get(stop_token));
+    auto expected = this->future_.Get(stop_token);
     ASSERT_FALSE(expected.has_value());
     EXPECT_EQ(expected.error(), Error::kFutureAlreadyRetrieved);
 }

score/concurrency/task_result_test.cpp

@@ -157,7 +157,7 @@ class TaskResultContinuationTest : public ::testing::Test
   public:
     typename T::TaskType Make()
     {
-        return std::move(T::Make(promise_));
+        return T::Make(promise_);
     }
 
     void ExpectCallNTimes(std::uint16_t n)