flatbuffers: add flatbuffers allocator test#211
Open
paulquiring wants to merge 1 commit into
Open
Conversation
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
|
The created documentation from the pull request is available at: docu-html |
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
commented
Jun 9, 2026
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
commented
Jun 19, 2026
paulquiring
commented
Jun 24, 2026
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
commented
Jun 25, 2026
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
e5e076d to
9b92189
Compare
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
9b92189 to
7dc5e84
Compare
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
commented
Jun 25, 2026
|
|
||
| TEST(AllocatorTest, AllocateReturnsNonNull) | ||
| { | ||
| RecordProperty("Verifies", "::flatbuffers::Allocator::allocate, ::flatbuffers::Allocator::deallocate"); |
Contributor
Author
There was a problem hiding this comment.
To use a namespace element in the Verifies RecordProperty is not defined in the process.
RecordProperty("Verifies", "::flatbuffers::Allocator::allocate, ::flatbuffers::Allocator::deallocate");we might want to include that since this is common practice inside baselibs.
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
As far as I remember, the process expects either FullyVerifies or PartiallyVerifies. Currently they are not really used in baselibs
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
7dc5e84 to
8ca915f
Compare
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
8ca915f to
2c5f202
Compare
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
commented
Jun 26, 2026
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
47ff5d4 to
b4b5b39
Compare
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
b4b5b39 to
68b198e
Compare
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
68b198e to
56ce4a4
Compare
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
paulquiring
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
4og
reviewed
Jun 26, 2026
|
|
||
| cc_test( | ||
| name = "flatbuffers_cpp_library_test", | ||
| testonly = 1, |
Member
There was a problem hiding this comment.
Can this rather be set to True instead of 1?
|
|
||
| TEST(AllocatorTest, AllocateReturnsNonNull) | ||
| { | ||
| RecordProperty("Verifies", "::flatbuffers::Allocator::allocate, ::flatbuffers::Allocator::deallocate"); |
Member
There was a problem hiding this comment.
As far as I remember, the process expects either FullyVerifies or PartiallyVerifies. Currently they are not really used in baselibs
paulquiring
force-pushed
the
paulquiring/add_flatbuffers_allocator_ut
branch
from
56ce4a4 to
651c3b5
Compare
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
paulquiring
requested a deployment
to
workflow-approval
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial unit test for the FlatBuffer wrapper library is added.
This unit test will serve as a template for all subsequent unit tests.
Closes: #127