fix type warnings

Author: AlexanderLanin

score_pytest/attribute_plugin.py

@@ -90,8 +90,8 @@ def decorator(func: TestFunction) -> TestFunction:
 def pytest_runtest_makereport(item: pytest.Item, call: pytest.CallInfo[None]):
     """Attach file and line info to the report for use in junitxml output."""
 
-    outcome = yield
-    report = outcome.get_result()
+    outcome = yield  # pyright: ignore[reportUnknownVariableType]
+    report = outcome.get_result()  # pyright: ignore[reportUnknownVariableType]
 
     if report.when != "call":
         return
@@ -115,7 +115,7 @@ def pytest_runtest_makereport(item: pytest.Item, call: pytest.CallInfo[None]):
         )
 
     if isinstance(marker.args[0], dict):
-        for k, v in marker.args[0].items():
+        for k, v in marker.args[0].items():  # pyright: ignore[reportUnknownVariableType]
             item.user_properties.append((k, str(v)))
 
 
@@ -124,11 +124,11 @@ def add_file_and_line_attr(
     record_xml_attribute: Callable[[str, str], None], request: pytest.FixtureRequest
 ) -> None:
     """Adding line & file to the <testcase> attribute in the XML"""
-    node = request.node
-    raw_file_path, line_number, _ = node.location
+    node = request.node  # pyright: ignore[reportUnknownVariableType]
+    raw_file_path, line_number, _ = node.location  # pyright: ignore[reportUnknownVariableType]
 
     # turning `../../../_main/<file_path>` into => <filepath>
-    clean_file_path = raw_file_path.split("_main/")[-1]
+    clean_file_path = raw_file_path.split("_main/")[-1]  # pyright: ignore[reportUnknownVariableType]
     record_xml_attribute("file", str(clean_file_path))
     # Convert pytest's 0-based source line number to 1-based numbering for XML output.
     record_xml_attribute("line", str(line_number + 1))

score_pytest/tests/test_rules_are_working_correctly.py

@@ -10,5 +10,5 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-def test_local_fixture_has_correct_value(fixture42):
+def test_score_pytest_loads_conftest(fixture42):  # pyright: ignore[reportMissingParameterType]
     assert fixture42 == 42

scripts_bazel/tests/traceability_gate_test.py

@@ -210,7 +210,7 @@ def test_gate_fail_on_broken_test_refs(
     monkeypatch: pytest.MonkeyPatch,
     capsys: pytest.CaptureFixture[str],
 ) -> None:
-    metrics_by_type = {
+    metrics_by_type: dict[str, object] = {
         "tool_req": {
             "include_not_implemented": False,
             "include_external": False,
@@ -223,7 +223,7 @@ def test_gate_fail_on_broken_test_refs(
             "fully_linked_pct": 100.0,
         }
     }
-    tests = {
+    tests: dict[str, object] = {
         "total": 2,
         "linked_to_requirements": 2,
         "linked_to_requirements_pct": 100.0,
@@ -248,7 +248,7 @@ def test_gate_specific_need_type_only(
     monkeypatch: pytest.MonkeyPatch,
     capsys: pytest.CaptureFixture[str],
 ) -> None:
-    metrics_by_type = {
+    metrics_by_type: dict[str, object] = {
         "tool_req": {
             "include_not_implemented": False,
             "include_external": False,
@@ -272,7 +272,7 @@ def test_gate_specific_need_type_only(
             "fully_linked_pct": 0.0,
         },
     }
-    tests = {
+    tests: dict[str, object] = {
         "total": 1,
         "linked_to_requirements": 1,
         "linked_to_requirements_pct": 100.0,
@@ -349,7 +349,7 @@ def test_gate_missing_metrics_by_type_returns_error(
     monkeypatch: pytest.MonkeyPatch,
     capsys: pytest.CaptureFixture[str],
 ) -> None:
-    payload = {
+    payload: dict[str, object] = {
         "schema_version": "2",
         "generated_by": "sphinx_build",
         "overall_metrics": {
@@ -383,7 +383,7 @@ def test_gate_missing_tests_section_returns_error(
     monkeypatch: pytest.MonkeyPatch,
     capsys: pytest.CaptureFixture[str],
 ) -> None:
-    metrics_by_type = {
+    metrics_by_type: dict[str, object] = {
         "tool_req": {
             "include_not_implemented": False,
             "include_external": False,
@@ -396,7 +396,7 @@ def test_gate_missing_tests_section_returns_error(
             "fully_linked_pct": 100.0,
         }
     }
-    payload = {
+    payload: dict[str, object] = {
         "schema_version": "2",
         "generated_by": "sphinx_build",
         "overall_metrics": _derive_overall_metrics(metrics_by_type),

src/extensions/score_metamodel/checks/check_options.py

@@ -243,8 +243,9 @@ def check_extra_options(
         "mandatory_links",
         "optional_links",
     ):
-        assert need_options[o] is not None
-        allowed_options.update(need_options[o].keys())
+        val = need_options[o]
+        assert val is not None
+        allowed_options.update(val.keys())
 
     extra_options = [
         option

src/extensions/score_metamodel/tests/test_graph_checks.py

@@ -41,20 +41,6 @@ def filter_is_external(self, is_external: bool) -> DummyNeedsView:
         )
 
 
-class NeedObject(dict):
-    """Need object that supports both mapping and attribute style access used by code."""
-
-    @property
-    def id(self) -> str:
-        """Return need identifier."""
-        return self["id"]
-
-    @property
-    def _links(self) -> dict[str, list[NeedObject]]:
-        """Return links map."""
-        return self["links"]
-
-
 def test_eval_need_check_invalid_check_parts_raises_value_error() -> None:
     """Raise error when a check does not contain exactly three parts."""
     log = fake_check_logger()

src/extensions/score_metrics/tests/test_sphinx_filters.py

@@ -69,7 +69,7 @@ def test_generic_pie_items_by_tag_matches_source_by_id_prefix() -> None:
     assert results == [1, 1]
 
 
-EXAMPLE_METRICS = {
+EXAMPLE_METRICS: dict[str, object] = {
     "schema_version": "1",
     "generated_by": "sphinx_build",
     "overall_metrics": {
@@ -110,15 +110,15 @@ def test_get_key_values_raises_key_error_when_global_is_empty() -> None:
     """It raises KeyError if CALCULATED_METRICS is still empty."""
     results: list[int] = []
     with pytest.raises(KeyError):
-        sphinx_filters._get_key_values(results, ["overall_metrics:total"])
+        sphinx_filters._get_key_values(results, ["overall_metrics:total"])  # pyright: ignore[reportPrivateUsage]
 
 
 def test_get_key_values_appends_values_when_metrics_loaded() -> None:
     """It appends resolved integer values once metrics data is loaded."""
     sphinx_filters.CALCULATED_METRICS = EXAMPLE_METRICS
     results: list[int] = []
 
-    sphinx_filters._get_key_values(
+    sphinx_filters._get_key_values(  # pyright: ignore[reportPrivateUsage]
         results,
         [
             "overall_metrics:total",

src/extensions/score_metrics/tests/test_traceability_metrics.py

@@ -43,7 +43,9 @@ def test_get_need_types_by_tags_returns_matching_directives_only() -> None:
             },
             "optional_options": {},
             "mandatory_links": {},
+            "mandatory_links_str": {},
             "optional_links": {},
+            "optional_links_str": {},
         },
         {
             "title": "Test Type Verification",
@@ -57,7 +59,9 @@ def test_get_need_types_by_tags_returns_matching_directives_only() -> None:
             },
             "optional_options": {},
             "mandatory_links": {},
+            "mandatory_links_str": {},
             "optional_links": {},
+            "optional_links_str": {},
         },
         {
             "title": "Test Type Extra",
@@ -71,7 +75,9 @@ def test_get_need_types_by_tags_returns_matching_directives_only() -> None:
             },
             "optional_options": {},
             "mandatory_links": {},
+            "mandatory_links_str": {},
             "optional_links": {},
+            "optional_links_str": {},
         },
     ]
     result = metrics.get_need_types_by_tags(needs, {"verification", "requirement"})
@@ -98,7 +104,9 @@ def test_get_need_types_by_tags_returns_empty_on_non_match() -> None:
             },
             "optional_options": {},
             "mandatory_links": {},
+            "mandatory_links_str": {},
             "optional_links": {},
+            "optional_links_str": {},
         },
     ]
     result = metrics.get_need_types_by_tags(needs, {"requirements_without_proccess"})

src/extensions/score_metrics/traceability_metrics.py

@@ -28,7 +28,7 @@
 from sphinx_needs.data import NeedsView, SphinxNeedsData
 from sphinx_needs.need_item import NeedItem
 
-CALCULATED_METRICS = {}
+CALCULATED_METRICS: dict[str, object] = {}
 
 
 def get_need_types_by_tags(needs: list[ScoreNeedType], tags: set[str]) -> list[str]:
@@ -44,7 +44,7 @@ def get_need_types_by_tags(needs: list[ScoreNeedType], tags: set[str]) -> list[s
     return found_need_types
 
 
-def is_non_empty(value: Any) -> bool:
+def is_non_empty(value: object) -> bool:
     """Return True if value should be treated as present for traceability checks."""
     if isinstance(value, str):
         return bool(value.strip())
@@ -60,7 +60,7 @@ def safe_percent(numerator: int, denominator: int) -> float:
 
 def calculate_requirement_metrics(
     current_requirement_needs: list[NeedItem],
-) -> dict[str, Any]:
+) -> dict[str, int | float]:
     """Calculate requirement traceability statistics for links and completeness."""
     total = len(current_requirement_needs)
     reqs_with_code_link = 0
@@ -94,7 +94,7 @@ def calculate_requirement_metrics(
 
 def calculate_test_metrics(
     test_needs: list[NeedItem], all_needs: NeedsView
-) -> dict[str, Any]:
+) -> dict[str, object]:
     """Calculate testcase linkage and broken testcase-reference statistics."""
     tests_total = len(test_needs)
     tests_linked = 0
@@ -144,7 +144,7 @@ def calculate_full_need_metrics(app: Sphinx, include_external: bool):
     test_needs = list(all_needs.filter_types(["testcase"]).values())
     test_metrics = calculate_test_metrics(test_needs, all_needs)
 
-    metrics_by_type: dict[str, Any] = {}
+    metrics_by_type: dict[str, dict[str, int | float]] = {}
 
     # Metrics accumulated over all requirements types
     overall_metrics: dict[str, Any] = {
@@ -182,7 +182,7 @@ def calculate_full_need_metrics(app: Sphinx, include_external: bool):
         overall_metrics["fully_linked"], overall_metrics["total"]
     )
 
-    output: dict[str, Any] = {
+    output: dict[str, object] = {
         "schema_version": "2",
         "generated_by": "sphinx_build",
         "overall_metrics": overall_metrics,

src/incremental_dirty_build_test.py

@@ -15,14 +15,16 @@
 
 from pathlib import Path
 
+from pyfakefs.fake_filesystem import FakeFilesystem as FFS
+
 from incremental import clean_builddir_if_stale, update_module_hash
 
 _BUILD = Path("/build")
 _MODULE = Path("/MODULE.bazel")
 _LOCK = Path("/MODULE.bazel.lock")
 
 
-def _simulate_old_state(fs, warnings: str | None) -> None:
+def _simulate_old_state(fs: FFS, warnings: str | None) -> None:
     """Helper function to set up a build directory with an old hash and warnings."""
 
     fs.create_dir(_BUILD)
@@ -33,7 +35,9 @@ def _simulate_old_state(fs, warnings: str | None) -> None:
         fs.create_file(_BUILD / "warnings.txt", contents=warnings)
 
 
-def test_clean_removes_build_dir_when_previous_build_had_warnings(fs) -> None:
+def test_clean_removes_build_dir_when_previous_build_had_warnings(
+    fs: FFS,
+) -> None:
     """If warnings.txt exists and is not empty, the build dir is removed."""
 
     _simulate_old_state(fs, warnings="WARNING: something went wrong")
@@ -43,7 +47,7 @@ def test_clean_removes_build_dir_when_previous_build_had_warnings(fs) -> None:
     assert not _BUILD.exists()
 
 
-def test_clean_keeps_build_dir_when_warnings_txt_is_empty(fs) -> None:
+def test_clean_keeps_build_dir_when_warnings_txt_is_empty(fs: FFS) -> None:
     """If warnings.txt exists and is empty, the build dir is kept."""
 
     _simulate_old_state(fs, warnings="")
@@ -53,7 +57,7 @@ def test_clean_keeps_build_dir_when_warnings_txt_is_empty(fs) -> None:
     assert _BUILD.exists()
 
 
-def test_clean_is_noop_when_warnings_txt_is_absent(fs) -> None:
+def test_clean_is_noop_when_warnings_txt_is_absent(fs: FFS) -> None:
     """If warnings.txt does not exist, the build dir is kept (no error)."""
 
     _simulate_old_state(fs, warnings=None)
@@ -63,13 +67,15 @@ def test_clean_is_noop_when_warnings_txt_is_absent(fs) -> None:
     assert _BUILD.exists()
 
 
-def test_clean_is_noop_when_build_dir_is_absent(fs) -> None:
+def test_clean_is_noop_when_build_dir_is_absent(fs: FFS) -> None:
     fs.create_file(_MODULE, contents="stable")
 
     clean_builddir_if_stale(_BUILD, [_MODULE])
 
 
-def test_module_changed_removes_build_dir_when_one_sentinel_file_changed(fs) -> None:
+def test_module_changed_removes_build_dir_when_one_sentinel_file_changed(
+    fs: FFS,
+) -> None:
     _simulate_old_state(fs, warnings=None)
 
     _LOCK.write_bytes(b"new lock")
@@ -78,15 +84,17 @@ def test_module_changed_removes_build_dir_when_one_sentinel_file_changed(fs) ->
     assert not _BUILD.exists()
 
 
-def test_module_changed_keeps_build_dir_when_all_sentinel_files_unchanged(fs) -> None:
+def test_module_changed_keeps_build_dir_when_all_sentinel_files_unchanged(
+    fs: FFS,
+) -> None:
     _simulate_old_state(fs, warnings=None)
 
     clean_builddir_if_stale(_BUILD, [_MODULE, _LOCK])
 
     assert _BUILD.exists()
 
 
-def test_module_change_after_successful_build_forces_clean(fs) -> None:
+def test_module_change_after_successful_build_forces_clean(fs: FFS) -> None:
     _simulate_old_state(fs, warnings=None)
 
     _MODULE.write_bytes(b"version 2")
@@ -95,7 +103,7 @@ def test_module_change_after_successful_build_forces_clean(fs) -> None:
     assert not _BUILD.exists()
 
 
-def test_missing_hash_file_triggers_clean(fs) -> None:
+def test_missing_hash_file_triggers_clean(fs: FFS) -> None:
     """If _build/ exists but hash file is absent, treat as stale (e.g. upgrade from old version)."""
     fs.create_dir(_BUILD)
     fs.create_file(_MODULE, contents="stable")

src/tests/test_consumer.py

@@ -348,7 +348,7 @@ def _make_params() -> list[pytest.param]:  # type: ignore[type-arg]
                         id=f"{repo.name}-{override}-{_cmd_id(cmd)}",
                     )
                 )
-    return params
+    return params  # pyright: ignore[reportUnknownVariableType]
 
 
 @pytest.mark.parametrize("repo, override_type, cmd", _make_params())