fix broken tests

Author: AdhamN861

scripts_bazel/tests/generate_sourcelinks_cli_test.py

@@ -54,10 +54,11 @@ def some_function():
     with open(output_file) as f:
         data: list[dict[str, str | int]] = json.load(f)
     assert isinstance(data, list)
-    assert len(data) > 0
+    # First element is the metadata dict; there must be at least one need entry after it
+    assert len(data) > 1
 
-    # Verify schema of each entry
-    for entry in data:
+    # Verify schema of each need entry (skip the first metadata element)
+    for entry in data[1:]:
         assert "file" in entry
         assert "line" in entry
         assert "tag" in entry
@@ -71,4 +72,4 @@ def some_function():
         assert isinstance(entry["need"], str)
         assert isinstance(entry["full_line"], str)
 
-    assert any(entry["need"] == "tool_req__docs_arch_types" for entry in data)
+    assert any(entry["need"] == "tool_req__docs_arch_types" for entry in data[1:])

scripts_bazel/tests/merge_sourcelinks_test.py

@@ -23,18 +23,21 @@
 
 def test_merge_sourcelinks_basic(tmp_path: Path) -> None:
     """Test basic merge functionality."""
-    # Create test JSON files with correct schema
+    # Each sourcelinks JSON starts with a metadata dict followed by need entries
+    local_meta = {"repo_name": "local_repo", "hash": "", "url": ""}
+
     file1 = tmp_path / "links1.json"
     file1.write_text(
         json.dumps(
             [
+                local_meta,
                 {
                     "file": "test1.py",
                     "line": 10,
                     "tag": "# req-Id:",
                     "need": "tool_req__docs_arch_types",
                     "full_line": "# req-Id: tool_req__docs_arch_types",
-                }
+                },
             ]
         )
     )
@@ -43,17 +46,22 @@ def test_merge_sourcelinks_basic(tmp_path: Path) -> None:
     file2.write_text(
         json.dumps(
             [
+                local_meta,
                 {
                     "file": "test2.py",
                     "line": 20,
                     "tag": "# req-Id:",
                     "need": "gd_req__req_validity",
                     "full_line": "# req-Id: gd_req__req_validity",
-                }
+                },
             ]
         )
     )
 
+    # known_good.json is required by the script; for local_repo it is never read
+    known_good_file = tmp_path / "known_good.json"
+    known_good_file.write_text(json.dumps({"modules": {}}))
+
     output_file = tmp_path / "merged.json"
 
     result = subprocess.run(
@@ -62,6 +70,8 @@ def test_merge_sourcelinks_basic(tmp_path: Path) -> None:
             _MY_PATH.parent / "merge_sourcelinks.py",
             "--output",
             str(output_file),
+            "--known_good",
+            str(known_good_file),
             str(file1),
             str(file2),
         ],