PoC feature_in_id for single module repositories#604
Draft
MaximilianSoerenPollak wants to merge 2 commits into
Draft
PoC feature_in_id for single module repositories#604MaximilianSoerenPollak wants to merge 2 commits into
feature_in_id for single module repositories#604MaximilianSoerenPollak wants to merge 2 commits into
Conversation
MaximilianSoerenPollak
requested review from
AlexanderLanin,
dcalavrezo-qorix and
nradakovic
as code owners
MaximilianSoerenPollak
changed the title
feature_in_id for single module repositories
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
This is a suggestion/PoC on how we could allow for the
feature_in_idcheck to be kept but adapt it so that single feature /module repositories also pass this check.This is done here by adding an additional config parameter to the conf.py that defines strings that are also allowed in the feature_part of the id.
Now only if NONE of the 3 things (docpath, abbreviation or configured param) are found an error is thrown.
Fixes #596
🚨 Impact Analysis
✅ Checklist