Skip to content

test: cover more requirements#658

Open
a-zw wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:test-existing-implementation
Open

test: cover more requirements#658
a-zw wants to merge 6 commits into
eclipse-score:mainfrom
etas-contrib:test-existing-implementation

Conversation

@a-zw

@a-zw a-zw commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

📌 Description

Initially, just tried to cover some additional requirements with tests.
Then realized we should use versioned links now.
Also, upgraded some test links from "partially" to "fully" verified.
Also, extended source code linker to handle versioned links and warn if a test links to an older version.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 4fd4eb0b-4368-439a-a0dc-449bedca7e4a
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=ppc64le-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=riscv64-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=s390x-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=x86_64-unknown-linux-musl. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 7.586s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@a-zw
a-zw force-pushed the test-existing-implementation branch from c1a903a to f3c3909 Compare July 22, 2026 15:24
@a-zw
a-zw requested a review from Copilot July 22, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands the SCORE metamodel’s file-based RST test suite to cover additional safety, security, and standard-need type requirements, and wires these new test documents into Bazel test targets.

Changes:

  • Add new RST-based requirements tests for security analysis types and multiple safety analysis constraints (types, mandatory/optional attributes, and violates linkage).
  • Add a new attributes test to validate std_req / std_wp directive support.
  • Introduce new Bazel score_pytest targets to run safety/security file-based tests.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/extensions/score_metamodel/tests/rst/security/test_security_types.rst Adds RST-based tests for STRIDE threats and threat scenarios, including mandatory/optional attribute validation.
src/extensions/score_metamodel/tests/rst/safety/test_saf_violates.rst Adds tests intended to validate violates link target-type constraints for SAF needs.
src/extensions/score_metamodel/tests/rst/safety/test_saf_types.rst Adds tests ensuring SAF directive types exist and enforce mandatory attributes.
src/extensions/score_metamodel/tests/rst/safety/test_saf_optional_attrs.rst Adds tests for optional SAF attributes (mitigation_issue, safety_relevant, root_cause).
src/extensions/score_metamodel/tests/rst/safety/test_saf_mandatory_attrs.rst Adds tests for SAF mandatory attribute enforcement (including content requirements).
src/extensions/score_metamodel/tests/rst/attributes/test_std_types.rst Adds tests verifying std_req and std_wp directives are supported.
src/extensions/score_metamodel/BUILD Adds Bazel test targets for the new safety/security file-based RST test suites.

Comment thread src/extensions/score_metamodel/BUILD Outdated
Comment thread src/extensions/score_metamodel/BUILD Outdated
Comment thread src/extensions/score_metamodel/tests/rst/attributes/test_std_types.rst Outdated
@a-zw
a-zw force-pushed the test-existing-implementation branch from 202a081 to 0f50d83 Compare July 23, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants