verification report need type#660
Open
FScholPer wants to merge 1 commit into
Open
Conversation
Adds the mod_ver_report need type to the metamodel with an evidence extra link, documents the tool requirement, and adds option tests. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
FScholPer
requested review from
AlexanderLanin,
MaximilianSoerenPollak,
dcalavrezo-qorix and
nradakovic
as code owners
July 23, 2026 14:55
6 tasks
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
FScholPer
changed the title
aschemmel-tech
left a comment
aschemmel-tech
left a comment
Contributor
There was a problem hiding this comment.
Made some remarks, not crucial for the PoC
| # req-Id: tool_req__docs_verification_report_need | ||
| verification_method: ^.*$ | ||
| optional_options: | ||
| requirements_coverage_percent: ^(100|[1-9]?[0-9])$ |
Contributor
There was a problem hiding this comment.
not clear what can be seen here. maybe call it "requirements_tests_completely_passed_percent"
| verification_method: ^.*$ | ||
| optional_options: | ||
| requirements_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| structural_coverage_percent: ^(100|[1-9]?[0-9])$ |
Contributor
There was a problem hiding this comment.
branch coverage is also structural coverage, so maybe call "line/block_coverage_percent" (depending what our selected tool supports)
| requirements_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| structural_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| branch_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| verdict: ^(pass|fail|open)$ |
Contributor
There was a problem hiding this comment.
giving a verdict is not part of the process, who would give it? based on what ...? I think we had this more in the release note.
| structural_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| branch_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| verdict: ^(pass|fail|open)$ | ||
| report_version: ^.*$ |
Contributor
There was a problem hiding this comment.
every needs element has a version attribute. What is special about this?
| branch_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| verdict: ^(pass|fail|open)$ | ||
| report_version: ^.*$ | ||
| release_baseline: ^.*$ |
Contributor
There was a problem hiding this comment.
I would still prefer: "The verification report is valid for the module version tagged together with the report" as written in the template.
| verification_method: ^.*$ | ||
| optional_options: | ||
| requirements_coverage_percent: ^(100|[1-9]?[0-9])$ | ||
| structural_coverage_percent: ^(100|[1-9]?[0-9])$ |
Contributor
There was a problem hiding this comment.
An overall value I do not think helpful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #611
Split out of #612 (verification part). The inspection-record part is in a separate PR.
📌 Description
Adds a machine-readable module verification report need type to the metamodel.
metamodel.yaml: newmod_ver_reportneed type (prefix: mod_vrep__) classifying a report bysafety,security,statusandverification_method, with optional coverage/verdict/version attributes; linksbelongs_toamodand optionallycontains/covers/evidence/realizes. Adds theevidenceextra link (evidence/evidence_for) it depends on.requirements.rst: new "Verification Evidence" section withtool_req__docs_verification_report_need, plus theVerifrow in the requirements overview table.rst/options/test_options_verification_report.rstcovering a valid report and an invalidverdictvalue.🚨 Impact Analysis
✅ Checklist
Frank Scholter Peres frank.scholter_peres@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH
Provider Information