Skip to content

make satisfied_by mandatory#662

Open
antonkri wants to merge 2 commits into
mainfrom
ankr_mm_upd_satisfied_by_mand
Open

make satisfied_by mandatory#662
antonkri wants to merge 2 commits into
mainfrom
ankr_mm_upd_satisfied_by_mand

Conversation

@antonkri

Copy link
Copy Markdown
Contributor

📌 Description

Currently there is no mandatory link between feat <-> feat_req and comp <-> comp_req. This makes it impossible, at least for automated tools, to map requirements to concrete feature or component.

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 50295ee0-a138-4594-9572-dca99a069fa8
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=ppc64le-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=riscv64-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=s390x-unknown-linux-gnu. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
DEBUG: /home/runner/.bazel/external/rules_python+/python/private/repo_utils.bzl:101:16: 
rules_python:coverage_dep WARNING: rules_python's bundled coverage tool has no wheel for python_version=3.12.13, platform=x86_64-unknown-linux-musl. `bazel coverage` will produce empty lcov for py_test targets in this configuration. Either pin python_version to a version in the bundled set (see python/private/coverage_deps.bzl), or configure coverage manually via py_runtime.coverage_tool. See docs/coverage.md.
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
WARNING: Target pattern parsing failed.
ERROR: Skipping '//src:license-check': no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
ERROR: no such target '//src:license-check': target 'license-check' not declared in package 'src' defined by /home/runner/work/docs-as-code/docs-as-code/src/BUILD
INFO: Elapsed time: 8.142s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

aschemmel-tech
aschemmel-tech previously approved these changes Jul 24, 2026

@aschemmel-tech aschemmel-tech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is according to https://eclipse-score.github.io/process_description/main/process_areas/requirements_engineering/guidance/requirements_process_reqs.html#gd_req__req_linkage_architecture_mandatory and process metamodel definition. Change from belongs_to to satisfied_by should already have been done in the module repositories

@anmittag anmittag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonkri in case the mandatory requirement is missing, does it create a warning or an error?

FScholPer
FScholPer previously approved these changes Jul 24, 2026
AlexanderLanin

This comment was marked as duplicate.

@AlexanderLanin AlexanderLanin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix score repository before making the attribute mandatory, otherwise we will not be able to roll out docs-as-code

@AlexanderLanin

Copy link
Copy Markdown
Member

@antonkri in case the mandatory requirement is missing, does it create a warning or an error?

mandatory violations are hard errors

@antonkri

antonkri commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

@antonkri in case the mandatory requirement is missing, does it create a warning or an error?

mandatory violations are hard errors

@AlexanderLanin if we introduce it here, then it doesn't mean that score or module repos will fail, as they use the older version of docs-as-code. So I think that is actually the workflow: you update the checks in docs-as-code -> inform everyone -> everyone who wants to use newer version need to fix findings. Other way around you will need week if not months as there is no pressure

@MaximilianSoerenPollak

Copy link
Copy Markdown
Contributor

@antonkri Can you run pre-commit run -a so the stuff is fixed that currently is failing

@antonkri
antonkri dismissed stale reviews from FScholPer and aschemmel-tech via 5abedb6 July 24, 2026 13:53
@antonkri

Copy link
Copy Markdown
Contributor Author

@antonkri Can you run pre-commit run -a so the stuff is fixed that currently is failing

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

6 participants