Skip to content

Commit 74c0a87

Browse files
committed
ci(docs): harden docs.yml workflow security
- Replace pull_request_target with pull_request - Tighten top-level permissions to contents: read - Guard docs-verify to skip fork PRs - Restrict docs-build to non-PR events only - Remove commented-out unit-tests block
1 parent 313f28d commit 74c0a87

1 file changed

Lines changed: 5 additions & 11 deletions

File tree

.github/workflows/docs.yml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,10 @@
1313
name: Verify and Build Docs
1414

1515
permissions:
16-
contents: write
17-
pages: write
18-
pull-requests: write
19-
id-token: write
16+
contents: read
2017

2118
on:
22-
pull_request_target:
19+
pull_request:
2320
types: [opened, reopened, synchronize]
2421
push:
2522
branches:
@@ -31,20 +28,17 @@ on:
3128

3229
jobs:
3330
docs-verify:
31+
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
3432
uses: eclipse-score/cicd-workflows/.github/workflows/docs-verify.yml@c1c90b1a82a1fab0fc202979dde6686b2162d5a8 # v0.0.0
3533
permissions:
3634
pull-requests: write
3735
contents: read
3836
with:
3937
bazel-docs-verify-target: "--lockfile_mode=error //:docs"
4038

41-
# unit-tests:
42-
# uses: ./.github/workflows/itf.yml
43-
# secrets: inherit
44-
4539
docs-build:
46-
needs: [docs-verify] # add unit-tests here when ready
47-
if: ${{ always() && needs.docs-verify.result == 'success' }}
40+
needs: [docs-verify]
41+
if: github.event_name != 'pull_request'
4842
uses: eclipse-score/cicd-workflows/.github/workflows/docs.yml@c1c90b1a82a1fab0fc202979dde6686b2162d5a8 # v0.0.0
4943
permissions:
5044
contents: write

0 commit comments

Comments
 (0)