Introducing report_running() API & Cleanup lifecycle_client target (#239)

* Initial report_running files

* Update LifeCycleManager to use report_running()

* Update year in copyright

* Remove mw::log dependency, adjust include prefix & visibility

* Rename lifecycleclient.cpp to lifecycle_client.cpp

* Add internal bazel target for old-school LifecycleClient

* UT for score::mw::lifecycle::Run - generated by AI

* Get rid of uninteresting mock calls

* Mock targets invisible outside of package

* Build breaks on rust_supervised_app

* Fix rust_supervised_app

* Drop no longer needed dependency

* Clean up in build file

* Some todos added

* Misc changes

Drop lifecycle_client in include path
Adapt visibility of packages
Get rid of circular dependency between
lifecycle_internal and impl

* Add public aliases for mock, move pthread dependency

* Fix UT

* Move dependencies

* Remove application mock

* Align to internal branch

* Adjust visibility, get rid of unused aliases

* Fix bazel formatting

* Remove pthreads

* Minimal changes to make tests in config_management happy

* Make applicationcontainer_cc public

* Make everything public for now to maintain full backward compatibility

---------

Co-authored-by: Nicolas Fußberger <145956508+NicolasFussberger@users.noreply.github.com>

Author: TimoSteuerwaldETAS

score/launch_manager/BUILD

@@ -49,6 +49,7 @@ cc_library(
     hdrs = ["execution_error.h"],
     include_prefix = "score/mw/lifecycle",
     strip_include_prefix = "/score/launch_manager",
+    visibility = ["//score/launch_manager:__subpackages__"],
     deps = [
         "@score_baselibs//score/result",
     ],
@@ -62,6 +63,7 @@ cc_library(
     ],
     include_prefix = "score/mw/lifecycle",
     strip_include_prefix = "/score/launch_manager",
+    visibility = ["//score/launch_manager:__subpackages__"],
     deps = [
         ":error",
         "//score/launch_manager/daemon/src/common:identifier_hash",
@@ -71,10 +73,57 @@ cc_library(
 cc_test(
     name = "exec_error_domain_UT",
     srcs = ["exec_error_domain_UT.cpp"],
-    visibility = ["//tests:__subpackages__"],
+    visibility = ["//visibility:private"],
     deps = [
         ":error",
         "@googletest//:gtest_main",
         "@score_baselibs//score/result",
     ],
 )
+
+alias(
+    name = "applicationcontext_mock_cc",
+    actual = "//score/launch_manager/lifecycle_client:applicationcontext_mock",
+)
+
+alias(
+    name = "lifecycle_mock_cc",
+    actual = "//score/launch_manager/lifecycle_client:lifecycle_mock",
+)
+
+alias(
+    name = "report_running_mock_cc",
+    actual = "//score/launch_manager/lifecycle_client:report_running_mock",
+)
+
+# BEGIN: Fine granular targets only needed for testing purposes
+alias(
+    name = "aasapplicationcontainer_cc",
+    actual = "//score/launch_manager/lifecycle_client:aasapplicationcontainer",
+)
+
+alias(
+    name = "application_cc",
+    actual = "//score/launch_manager/lifecycle_client:application",
+)
+
+alias(
+    name = "applicationcontext_cc",
+    actual = "//score/launch_manager/lifecycle_client:applicationcontext",
+)
+
+alias(
+    name = "lifecyclemanager_cc",
+    actual = "//score/launch_manager/lifecycle_client:lifecyclemanager",
+)
+
+alias(
+    name = "report_running_cc",
+    actual = "//score/launch_manager/lifecycle_client:report_running",
+)
+
+alias(
+    name = "runapplication_cc",
+    actual = "//score/launch_manager/lifecycle_client:runapplication",
+)
+# END: Fine granular targets only needed for testing purposes

score/launch_manager/daemon/BUILD

@@ -12,26 +12,14 @@
 # *******************************************************************************
 load("@rules_cc//cc:defs.bzl", "cc_binary")
 
-alias(
-    name = "error",
-    actual = "//score/launch_manager:error",
-    visibility = ["//visibility:public"],
-)
-
-alias(
-    name = "error_event",
-    actual = "//score/launch_manager:error_event",
-    visibility = ["//visibility:public"],
-)
-
 cc_binary(
     name = "launch_manager",
     srcs = ["src/main.cpp"],
     linkopts = select({
         "@platforms//os:qnx": ["-lsecpol"],
         "@platforms//os:linux": ["-lpthread"],
     }),
-    visibility = ["//visibility:public"],
+    visibility = ["//score/launch_manager:__subpackages__"],
     deps = [
         "//score/launch_manager/daemon/src/alive_monitor",
         "//score/launch_manager/daemon/src/common:log",

score/launch_manager/daemon/src/alive_monitor/rust/BUILD

@@ -22,7 +22,6 @@ rust_library(
     visibility = ["//score:__subpackages__"],
     deps = [
         "//score/launch_manager:alive_cc",
-        "//score/launch_manager/lifecycle_client",
         "@score_crates//:libc",
     ],
 )

score/launch_manager/daemon/src/alive_monitor/rust/src/monitor.rs

@@ -15,7 +15,7 @@ use libc::{c_char, c_uint, c_void};
 use std::ffi::CString;
 use std::marker::PhantomData;
 
-#[link(name = "lifecycle_client")]
+#[link(name = "am-lib")]
 unsafe extern "C" {
     fn score_lcm_monitor_initialize(instanceSpecifier: *const c_char) -> *mut c_void;
     fn score_lcm_monitor_deinitialize(instance: *mut c_void);