Address review comments:

-use assert and ASSERT_TRUE safeguards

Signed-off-by: Sumitkumar Satpute sumitkumar.sa.satpute@bti.bmwgroup.com

Author: Sumitkumar Satpute

score/launch_manager/src/control_client/src/details/control_client_impl.cpp

@@ -12,6 +12,7 @@
  ********************************************************************************/
 
 #include <cstdint>
+#include <cassert>
 #include <map>
 #include <sys/stat.h>
 #include <thread>
@@ -94,7 +95,9 @@ ControlClientImpl::ControlClientImpl(std::function<void(const score::lcm::Execut
 
     ipc_channel_ = score::lcm::internal::ControlClientChannel::initializeControlClientChannel();
 
-    static_cast<void>(ipc_request_semaphore_.init(1U, false));
+    const auto init_result = ipc_request_semaphore_.init(1U, false);
+    assert((score::lcm::internal::osal::OsalReturnType::kSuccess == init_result) &&
+           "ControlClient semaphore initialization failed");
     ipc_response_thread_ = std::make_unique<std::thread>(&ControlClientImpl::run, this);
 }
 

score/launch_manager/src/daemon/src/alive_monitor/details/ifappl/MonitorIfDaemon_UT.cpp

@@ -74,7 +74,8 @@ struct MonitorIfDaemonFixture
     /// Initialize the IPC server so that peek/pop/hasOverflow use real shared memory.
     void initIpc()
     {
-        static_cast<void>(ipcServer.init(makeUniqueIpcName()));
+        ASSERT_TRUE(ipcServer.init(makeUniqueIpcName()) == ifappl::CheckpointIpcServer::EIpcInitResult::kOk)
+            << "CheckpointIpcServer init failed";
     }
 
     /// Drive the process to the 'running' state and notify observers.