1212 ********************************************************************************/
1313#include " score/hm/health_monitor.h"
1414#include " score/hm/common.h"
15+ #include " score/hm/tag.h"
1516#include < gmock/gmock.h>
1617#include < gtest/gtest.h>
1718
@@ -24,34 +25,37 @@ class HealthMonitorTest : public ::testing::Test
2425// For first review round, only single test case to show up API
2526TEST_F (HealthMonitorTest, TestName)
2627{
27- auto builder_mon = deadline::DeadlineMonitorBuilder ()
28- .add_deadline (IdentTag (" deadline_1" ),
29- TimeRange (std::chrono::milliseconds (100 ), std::chrono::milliseconds (200 )))
30- .add_deadline (IdentTag (" deadline_2" ),
31- TimeRange (std::chrono::milliseconds (100 ), std::chrono::milliseconds (200 )));
32-
33- IdentTag ident (" monitor" );
28+ // Setup deadline monitor construction.
29+ const MonitorTag deadline_monitor_tag{" deadline_monitor" };
30+ auto deadline_monitor_builder =
31+ deadline::DeadlineMonitorBuilder ()
32+ .add_deadline (DeadlineTag (" deadline_1" ),
33+ TimeRange (std::chrono::milliseconds (100 ), std::chrono::milliseconds (200 )))
34+ .add_deadline (DeadlineTag (" deadline_2" ),
35+ TimeRange (std::chrono::milliseconds (100 ), std::chrono::milliseconds (200 )));
3436
3537 auto hm = HealthMonitorBuilder ()
36- .add_deadline_monitor (ident , std::move (builder_mon ))
38+ .add_deadline_monitor (deadline_monitor_tag , std::move (deadline_monitor_builder ))
3739 .with_internal_processing_cycle (std::chrono::milliseconds (50 ))
3840 .with_supervisor_api_cycle (std::chrono::milliseconds (50 ))
3941 .build ();
4042
41- auto deadline_monitor_res = hm.get_deadline_monitor (ident);
43+ // Obtain deadline monitor from HMON.
44+ auto deadline_monitor_res = hm.get_deadline_monitor (deadline_monitor_tag);
4245 EXPECT_TRUE (deadline_monitor_res.has_value ());
4346
4447 {
45- // Try again to get the same monitor
46- auto deadline_monitor_res = hm.get_deadline_monitor (ident );
48+ // Try again to get the same monitor.
49+ auto deadline_monitor_res = hm.get_deadline_monitor (deadline_monitor_tag );
4750 EXPECT_FALSE (deadline_monitor_res.has_value ());
4851 }
4952
5053 auto deadline_mon = std::move (*deadline_monitor_res);
5154
55+ // Start HMON.
5256 hm.start ();
5357
54- auto deadline_res = deadline_mon.get_deadline (IdentTag (" deadline_1" ));
58+ auto deadline_res = deadline_mon.get_deadline (DeadlineTag (" deadline_1" ));
5559
5660 {
5761 auto deadline_guard = deadline_res.value ().start ().value ();
0 commit comments