Skip to content

Commit 34a8fe2

Browse files
committed
log: fix stack use after scope in log init
Fix stack use after scope in stdout logger init.
1 parent da1eb6e commit 34a8fe2

4 files changed

Lines changed: 6 additions & 10 deletions

File tree

MODULE.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,11 @@ use_repo(oci, "debian-test-runtime", "debian-test-runtime_linux_amd64")
134134

135135
bazel_dep(name = "score_baselibs_rust", version = "0.1.2")
136136
bazel_dep(name = "score_baselibs", version = "0.2.8")
137+
git_override(
138+
module_name = "score_baselibs",
139+
commit = "d0145e0645d4fe9661a36c348f0e62e13cf73f98",
140+
remote = "https://github.com/eclipse-score/baselibs.git",
141+
)
137142

138143
# Hedron's Compile Commands Extractor for Bazel
139144
# https://github.com/hedronvision/bazel-compile-commands-extractor

MODULE.bazel.lock

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

score/health_monitor/src/cpp/BUILD

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,6 @@ cc_gtest_unit_test(
8080
"@platforms//os:qnx": ["-lsocket"],
8181
"@platforms//os:linux": [],
8282
}),
83-
# TODO(eclipse-score/baselibs#253): stack-use-after-scope in score_baselibs_rust
84-
# StdoutLoggerBuilder::SetAsDefaultLogger - context_ptr dangles after the
85-
# if-block destroys its std::string before the Rust FFI call reads it.
86-
tags = ["no-asan"],
8783
deps = [
8884
"//score/health_monitor/src/cpp:health_monitoring_cc_stub_supervisor",
8985
"//score/health_monitor/src/cpp/details:log_init",
@@ -99,9 +95,6 @@ cc_gtest_unit_test(
9995
"@platforms//os:qnx": ["-lsocket"],
10096
"@platforms//os:linux": [],
10197
}),
102-
tags = [
103-
"no-asan",
104-
],
10598
deps = [
10699
"//score/health_monitor/src/cpp:health_monitoring_cc_stub_supervisor",
107100
"//score/health_monitor/src/cpp/details:log_init",

score/health_monitor/src/cpp/details/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ cc_library(
1919
visibility = ["//score/health_monitor/src/cpp:__pkg__"],
2020
deps = [
2121
"@googletest//:gtest",
22-
"@score_baselibs_rust//src/log/stdout_logger_cpp_init",
22+
"@score_baselibs//src/log/stdout_logger_cpp_init",
2323
],
2424
)
2525

0 commit comments

Comments
 (0)