Skip to content

Commit a8ae92c

Browse files
committed
bazel: use profile-update=atomic
`bazel coverage` sometimes return negative count on U24. Use atomic profile update instead of ignoring the error.
1 parent 58d6d1b commit a8ae92c

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

.bazelrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ coverage --features=coverage
3030
coverage --combined_report=lcov
3131
coverage --cache_test_results=no
3232
coverage --test_tag_filters=-no-coverage
33+
coverage --copt=-fprofile-update=atomic
34+
coverage --linkopt=-fprofile-update=atomic
3335

3436
# Common Lifecycle Toolchain flags for build (do not use it in case of system toolchains!)
3537
build:toolchain_common --incompatible_strict_action_env

.github/workflows/code_coverage.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ jobs:
2929
bazel-target: "//score/..."
3030
bazel-config: "x86_64-linux"
3131
extra-bazel-flags: "--test_output=errors --nocache_test_results --lockfile_mode=error"
32-
genhtml-extra-flags: "--ignore-errors=negative"
3332
artifact-name-suffix: "_cpp"
3433
retention-days: 10
3534
min-coverage: 76

0 commit comments

Comments
 (0)