Feature/load new lifecycle config#208
Merged
NicolasFussberger merged 42 commits intoJun 11, 2026
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
paulquiring
reviewed
May 20, 2026
paulquiring
reviewed
May 20, 2026
paulquiring
reviewed
May 20, 2026
Contributor
|
review from my side is finished. |
SimonKozik
reviewed
May 21, 2026
paulquiring
suggested changes
May 21, 2026
TimoSteuerwaldETAS
approved these changes
Jun 8, 2026
paulquiring
reviewed
Jun 9, 2026
paulquiring
reviewed
Jun 9, 2026
paulquiring
reviewed
Jun 9, 2026
paulquiring
suggested changes
Jun 9, 2026
paulquiring
approved these changes
Jun 10, 2026
anmittag
approved these changes
Jun 11, 2026
LorantLipcsei-ETAS
pushed a commit
to etas-contrib/score_lifecycle
that referenced
this pull request
Jun 16, 2026
* Provide new configuration interfaces * Upgrade baselibs & flatbuffer version * Use baselibs flatbuffer helper * Config refactoring * Use bazel rule to generate fb file * Extend documentation * Narrow RecoveryAction options * Remove optional from required fields * Remove unrelated test output * Run formater on new code * Change method names to CamelCase * Move accessor method impl to cpp file * Add #endif comments * ConfigBuilder is no longer a nested class * Add assertions for required fields * Add assertion for sub-ms precision * Use uid_t and gid_t types * Implement Environment var classes * Scheduling policy as int * Refactor handling of mandatory and optional values * Upgrade to latest baselibs release This removes the baselibs override * Validation of secToMs conversion + more error logs * Add [[nodiscard]] to config API * Change namespace of new code * More doxygen documentation * Make kExpectedSchemaVersion a public member * Align to new folder structure * Split conversion functions to separate file * Add validation for alive supervision config * Add comments for method params in tests * Regenerate headers with newer flatc version * Add requireScalarValue helper function * Add validateRange helper method * Add optionalScalar helper method * Fix formatting * Remove now obsolete file * Configure uid/gid as int64 and validate range
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: The code is not actually in use yet. The python script which does the translation from the user-facing json configuration to the flatbuffer json format is not part of the PR and will be added in a follow up PR.
Furthermore, the launch manager code needs to be adapted to use the new structure.
Background:
Relates To: #209