Skip to content

Adding enum return type for SafeProcessMap#243

Merged
NicolasFussberger merged 4 commits into
eclipse-score:mainfrom
NemanjaTrifunovicRTRK:main
Jun 15, 2026
Merged

Adding enum return type for SafeProcessMap#243
NicolasFussberger merged 4 commits into
eclipse-score:mainfrom
NemanjaTrifunovicRTRK:main

Conversation

@NemanjaTrifunovicRTRK

Copy link
Copy Markdown
Contributor

Description

Extends SafeProcessMap with an enum class for the return value of public methods.

Changes

  • score/launch_manager/daemon/src/process_group_manager/details/safe_process_map.hpp

    • Updated public API with the enum class return value
  • score/launch_manager/daemon/src/process_group_manager/details/safe_process_map.cpp

    • Updated public API with the enum class return value
  • score/launch_manager/daemon/src/process_group_manager/details/process_info_node.cpp

    • Added comparison with the enum class return value
  • score/launch_manager/daemon/src/process_group_manager/details/os_handler.cpp

    • Added comparison with the enum class return value
  • score/launch_manager/daemon/src/process_group_manager/details/oshandler_UT.cpp

    • Updated Unit Tests
  • score/launch_manager/daemon/src/process_group_manager/details/safeprocessmap_UT.cpp

    • Updated Unit Tests

Notes

Only the public API is changed, the private method API and logic are not changed.

Verification

Verified with successful build and test execution

bazel build --config=x86_64-linux  //score/...
bazel test //examples/... --config=x86_64-linux --test_output=all --test_arg=-s
bazel test --config=x86_64-linux  //score/...

Closes #222

@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: ee61b17f-e3d3-45a0-8130-56b0746e9f47
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 10 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2720 targets configured)

Analyzing: target //:license-check (147 packages loaded, 5091 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8128 targets configured)

Analyzing: target //:license-check (158 packages loaded, 8130 targets configured)

Analyzing: target //:license-check (159 packages loaded, 8254 targets configured)

Analyzing: target //:license-check (162 packages loaded, 9816 targets configured)

INFO: Analyzed target //:license-check (163 packages loaded, 10268 targets configured).
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 21.598s, Critical Path: 2.62s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@NicolasFussberger NicolasFussberger merged commit 262af6a into eclipse-score:main Jun 15, 2026
20 checks passed
LorantLipcsei-ETAS pushed a commit to etas-contrib/score_lifecycle that referenced this pull request Jun 16, 2026
* Adding enum return type for SafeProcessMap

* Adding small fixes

* Fixing comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Small Improvement: Improve SafeProcessMap by returning an enum instead of int

3 participants