Remove test log display from docs and clean up conf.py#283
Open
shegazyy wants to merge 1 commit into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
Contributor
Author
|
Hey @AlexanderLanin 🙏 ready for review whenever you have a moment! |
|
The created documentation from the pull request is available at: docu-html |
The DisplayTestLogs Sphinx directive collected bazel-testlogs at build time and embedded them in the verification report. This had two problems: - The directive was registered in the local conf.py which is not executed in the score reference integration (docs-as-code), making it a no-op in official releases. - The project has decided not to include test logs in documentation. Remove the directive class, its registration, and the "Test Log Files" section in statistics.rst. Also drop the now-unused docutils imports. Closes eclipse-score#266
79fd187 to
5e0cc09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DisplayTestLogs Sphinx directive collected bazel-testlogs at build time and embedded them in the verification report. This had two problems:
Remove the directive class, its registration, and the "Test Log Files" section in statistics.rst. Also drop the now-unused docutils imports.
Closes #266