Fix FlatBuffers field names to use lowercase snake_case in lm_flatcfg.fbs#290
Open
shegazyy wants to merge 2 commits into
Open
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
533c77b to
f9787cf
Compare
Rename all camelCase/PascalCase field names in lm_flatcfg.fbs to lowercase_snake_case per FlatBuffers naming conventions. The binary format is unaffected because field identity is determined by the id:N attribute, not the field name. Update all call sites in configuration_manager.cpp to use the new generated accessor names. Issue: eclipse-score#288
Replace all old camelCase/PascalCase dict keys in lifecycle_config.py with the renamed snake_case field names to match the updated schema. Update the three expected-output lm_demo.json fixture files accordingly so integration tests continue to pass. Issue: eclipse-score#288
f9787cf to
ba39318
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FlatBuffers compiler warns when field names do not follow lowercase snake_case convention. Rename all non-conforming fields in lm_flatcfg.fbs (e.g. versionMajor -> version_major, startupConfig -> startup_config). Binary compatibility is preserved because field IDs (id:N) are unchanged.
Update configuration_manager.cpp to use the new generated accessor names, and update the expected JSON output fixtures in the config_mapping tests.
Closes #288