Skip to content

Fix FlatBuffers field names to use lowercase snake_case in lm_flatcfg.fbs#290

Open
shegazyy wants to merge 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/flatbuffers-snake-case-field-names
Open

Fix FlatBuffers field names to use lowercase snake_case in lm_flatcfg.fbs#290
shegazyy wants to merge 2 commits into
eclipse-score:mainfrom
Valeo-S-CORE-Organization:fix/flatbuffers-snake-case-field-names

Conversation

@shegazyy

@shegazyy shegazyy commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

The FlatBuffers compiler warns when field names do not follow lowercase snake_case convention. Rename all non-conforming fields in lm_flatcfg.fbs (e.g. versionMajor -> version_major, startupConfig -> startup_config). Binary compatibility is preserved because field IDs (id:N) are unchanged.

Update configuration_manager.cpp to use the new generated accessor names, and update the expected JSON output fixtures in the config_mapping tests.

Closes #288

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: 6e48384d-f211-40e7-83db-96d2cbc966bf
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (34 packages loaded, 10 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (143 packages loaded, 1123 targets configured)

Analyzing: target //:license-check (151 packages loaded, 5484 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (161 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (162 packages loaded, 5547 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (164 packages loaded, 7434 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10275 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

Analyzing: target //:license-check (169 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 28.709s, Critical Path: 2.64s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 09:45 — with GitHub Actions Waiting
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 09:45 — with GitHub Actions Waiting
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 10:50 — with GitHub Actions Waiting
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 10:50 — with GitHub Actions Waiting
@shegazyy shegazyy force-pushed the fix/flatbuffers-snake-case-field-names branch from 533c77b to f9787cf Compare July 7, 2026 12:08
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 12:08 — with GitHub Actions Waiting
@shegazyy shegazyy requested a deployment to workflow-approval July 7, 2026 12:08 — with GitHub Actions Waiting
shegazyy added 2 commits July 8, 2026 15:28
Rename all camelCase/PascalCase field names in lm_flatcfg.fbs to
lowercase_snake_case per FlatBuffers naming conventions.

The binary format is unaffected because field identity is determined
by the id:N attribute, not the field name.

Update all call sites in configuration_manager.cpp to use the new
generated accessor names.

Issue: eclipse-score#288
Replace all old camelCase/PascalCase dict keys in lifecycle_config.py
with the renamed snake_case field names to match the updated schema.

Update the three expected-output lm_demo.json fixture files accordingly
so integration tests continue to pass.

Issue: eclipse-score#288
@shegazyy shegazyy force-pushed the fix/flatbuffers-snake-case-field-names branch from f9787cf to ba39318 Compare July 8, 2026 12:34
@shegazyy shegazyy requested a deployment to workflow-approval July 8, 2026 12:34 — with GitHub Actions Waiting
@shegazyy shegazyy requested a deployment to workflow-approval July 8, 2026 12:34 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

Flatbuffers warning about wrong case of field names

1 participant