Skip to content

Fix bugs in Semaphore::timedWait#292

Merged
NicolasFussberger merged 3 commits into
eclipse-score:mainfrom
etas-contrib:semaphore-timeout
Jul 8, 2026
Merged

Fix bugs in Semaphore::timedWait#292
NicolasFussberger merged 3 commits into
eclipse-score:mainfrom
etas-contrib:semaphore-timeout

Conversation

@danth

@danth danth commented Jul 8, 2026

Copy link
Copy Markdown
Contributor
  • It always returned OsalReturnType::kFail instead of OsalReturnType::kTimeout
  • It could wait much longer than the given time due to accumulated inaccuracies from std::this_thread::sleep_for

danth added 2 commits July 8, 2026 09:05
Previously it would always return `kFail`, so the caller could not differentiate timeouts from real errors.
Also it did not retry on `EINTR`.
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.6.0) and connecting to it...
INFO: Invocation ID: a164896b-447a-4900-ad9c-4cb82a10bca3
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (37 packages loaded, 10 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (128 packages loaded, 138 targets configured)

Analyzing: target //:license-check (152 packages loaded, 3674 targets configured)

Analyzing: target //:license-check (152 packages loaded, 6259 targets configured)

Analyzing: target //:license-check (161 packages loaded, 8249 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (164 packages loaded, 8271 targets configured)

Analyzing: target //:license-check (167 packages loaded, 10159 targets configured)

Analyzing: target //:license-check (168 packages loaded, 10283 targets configured)

INFO: Analyzed target //:license-check (169 packages loaded, 10409 targets configured).
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 23.599s, Critical Path: 2.55s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@NicolasFussberger NicolasFussberger merged commit b95aa4c into eclipse-score:main Jul 8, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Jul 8, 2026
@danth danth deleted the semaphore-timeout branch July 8, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants