Skip to content

Mb add mocks for unit testing#78

Merged
ramceb merged 1 commit into
mainfrom
mb_add_mocks_for_unit_testing
Mar 5, 2026
Merged

Mb add mocks for unit testing#78
ramceb merged 1 commit into
mainfrom
mb_add_mocks_for_unit_testing

Conversation

@ramceb

@ramceb ramceb commented Feb 16, 2026

Copy link
Copy Markdown
Contributor

This PR adds mocks for the lifecycle_client_api to allow unit testing for applications using it.

@github-actions

github-actions Bot commented Feb 16, 2026

Copy link
Copy Markdown

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 45d469d3-6741-4e68-9b11-6d61f1736f25
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (34 packages loaded, 9 targets configured)

Analyzing: target //:license-check (86 packages loaded, 9 targets configured)

Analyzing: target //:license-check (134 packages loaded, 2266 targets configured)

Analyzing: target //:license-check (148 packages loaded, 5748 targets configured)

Analyzing: target //:license-check (156 packages loaded, 6859 targets configured)

Analyzing: target //:license-check (159 packages loaded, 7809 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9829 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 9955 targets configured).
[1 / 14] [Prepa] Expanding template license.check.license_check
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.921s, Critical Path: 2.85s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions

Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@ramceb ramceb force-pushed the mb_add_mocks_for_unit_testing branch from be6f420 to 9d9f271 Compare February 16, 2026 14:33
@ramceb ramceb temporarily deployed to workflow-approval February 16, 2026 14:33 — with GitHub Actions Inactive
@ramceb ramceb temporarily deployed to workflow-approval February 16, 2026 14:33 — with GitHub Actions Inactive
@ramceb ramceb force-pushed the mb_add_mocks_for_unit_testing branch from 9d9f271 to c208bf5 Compare February 16, 2026 14:37
@ramceb ramceb temporarily deployed to workflow-approval February 16, 2026 14:37 — with GitHub Actions Inactive
@ramceb ramceb temporarily deployed to workflow-approval February 16, 2026 14:37 — with GitHub Actions Inactive
@ramceb ramceb force-pushed the mb_add_mocks_for_unit_testing branch from c208bf5 to 3dad8b5 Compare February 17, 2026 13:01
@ramceb ramceb temporarily deployed to workflow-approval February 17, 2026 13:01 — with GitHub Actions Inactive
@ramceb ramceb temporarily deployed to workflow-approval February 17, 2026 13:01 — with GitHub Actions Inactive

@eclipse-impl eclipse-impl left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fits the necessary usage on ConfigManagement.

@pawelrutkaq pawelrutkaq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on main

Comment thread src/lifecycle_client_lib/BUILD
@ramceb ramceb force-pushed the mb_add_mocks_for_unit_testing branch from 3dad8b5 to d03a115 Compare March 4, 2026 09:07
@ramceb ramceb temporarily deployed to workflow-approval March 4, 2026 09:07 — with GitHub Actions Inactive
@ramceb ramceb temporarily deployed to workflow-approval March 4, 2026 09:07 — with GitHub Actions Inactive

@MaciejKaszynski MaciejKaszynski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think score process allows for mocking in component tests also, so maybe it would be good to just have test/mocks but I'm not too fussed.

features = COMPILER_WARNING_FEATURES,
deps = [
":application_mock",
# "//platform/aas/lib/os/utils/mocklib:signal_mock",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line can be removed

@ramceb ramceb merged commit dbc6a81 into main Mar 5, 2026
18 of 19 checks passed
@ramceb ramceb deleted the mb_add_mocks_for_unit_testing branch March 5, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants