Commit 1e5d0dc
committed
below review comments fixed:
- Requirement IDs corrected to feat_req__lifecycle__recov_run_target_switch (removed the two nonexistent IDs).
- Workflow/BUILD : reverted the .github/workflows/test_and_docs.yml change (no more separate fit_daemon invocation) and instead wired the daemon/lmcontrol binaries into the existing fit/fit_daemon_lifecycle_arc_* targets in BUILD so the existing suite picks them up.
- replaced the log-grep-only tests with a real control-interface client (lmcontrol) issuing actual activate_target/status-query requests; renamed to test_activate_target_via_control_interface and test_status_query_returns_current_run_target; trimmed partially_verifies to only what's actually exercised; fixed mislabeled assertion messages.
- renamed the no-recovery test to test_persistency_continuity_across_sequential_writes with an accurate docstring; rewrote module/class docstrings to describe switch-to-fallback (not restart); deleted the dead _wait_for_process_restart.
- crash-sync marker, safer arg-format fallback, dynamic snapshot-id resolution, daemon start_new_session+killpg, append-mode logging, readiness polling instead of fixed sleep — all applied in daemon_helpers.py / persistency_recovery.py.
- deleted the empty itf/test_lifecycle.py placeholder and the dead helpers in lifecycle_scenario.py.
- Docs (LIFECYCLE_TESTS_SUMMARY.md) updated to match actual test names/behavior.1 parent daf417d commit 1e5d0dc
13 files changed
Lines changed: 1292 additions & 830 deletions
File tree
- .github/workflows
- feature_integration_tests
- itf
- test_cases
- configs
- tests/lifecycle
- test_scenarios
- cpp
- src/scenarios/lifecycle
- rust
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | 76 | | |
78 | 77 | | |
79 | 78 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
84 | | - | |
| 83 | + | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
91 | | - | |
92 | | - | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
95 | 97 | | |
96 | 98 | | |
97 | 99 | | |
98 | 100 | | |
99 | | - | |
100 | | - | |
101 | | - | |
| 101 | + | |
| 102 | + | |
102 | 103 | | |
103 | 104 | | |
104 | 105 | | |
| |||
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | | - | |
| 73 | + | |
73 | 74 | | |
74 | 75 | | |
75 | 76 | | |
| |||
101 | 102 | | |
102 | 103 | | |
103 | 104 | | |
| 105 | + | |
104 | 106 | | |
105 | 107 | | |
106 | | - | |
107 | | - | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
Lines changed: 7 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
62 | 65 | | |
63 | 66 | | |
64 | 67 | | |
| |||
75 | 78 | | |
76 | 79 | | |
77 | 80 | | |
78 | | - | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
79 | 84 | | |
80 | 85 | | |
81 | 86 | | |
| |||
88 | 93 | | |
89 | 94 | | |
90 | 95 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | 96 | | |
101 | 97 | | |
102 | 98 | | |
| |||
0 commit comments