Skip to content

Commit 302ff21

Browse files
committed
Address remaining PR #230 review findings
- §1: clarify NM and Diagnostic Services are PA1-only (no own repo, no known_good.json key); their PA2-PA5 cells render ❌ Open by design and they contribute 0 to the per-PA progress charts. - §2: cross-reference note explaining why no rows exist for them and what to do once their repos are created. - §4 PA5: drop the orphaned 5th pipe column on the Static Analysis row (silently dropped by Markdown renderers); promote the no-link discipline note to a blockquote below the table covering both Static and Dynamic Analysis.
1 parent 1842d2b commit 302ff21

1 file changed

Lines changed: 19 additions & 1 deletion

File tree

.github/skills/overall-status/SKILL.md

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,15 @@ Lifecycle · Security/Crypto · Diagnostic Services · NM · Some/IP
2222

2323
Excluded: **Orchestrator** — never add a row for it.
2424

25+
> **PA1-only modules: Diagnostic Services and NM.** Both modules have a row in
26+
> every PA table for layout consistency, but only the PA1 column carries real
27+
> data: they are tracked via `feature_request` issues in `eclipse-score/score`
28+
> (see §4.0 keyword map). They have **no own repository** and **no
29+
> `known_good.json` key** yet, so §2 and the Step 4 path-filter table have no
30+
> rows for them and their PA2–PA5 cells render as `❌ Open` (zero directives,
31+
> zero files). They still contribute `0` to the per-PA progress charts
32+
> (§6a.2) and are excluded from the coverage weighted mean (§7).
33+
2534
Five process areas, each with its own table:
2635

2736
| PA | Title | sphinx-needs tag | Columns |
@@ -51,6 +60,10 @@ Each module has content in **`eclipse-score/score`** (feature-level) and in its
5160
| Security/Crypto || `eclipse-score/inc_security_crypto` | `docs/features/security_crypto/**` |
5261
| Some/IP || `eclipse-score/inc_someip_gateway` | `docs/features/communication/some_ip_gateway/**` |
5362

63+
> **No row for Diagnostic Services or NM** — see §1. They are PA1-only;
64+
> PA2–PA5 cells render `❌ Open` until their own repos / `known_good.json`
65+
> keys exist, at which point a row must be added here **and** in Step 4.
66+
5467
> `eclipse-score/score` itself is pinned under key **`score_platform`** in the
5568
> **`tooling`** section of `known_good.json` (not `target_sw`). Use the helper
5669
> `pinned_ref()` in §6 below.
@@ -157,11 +170,16 @@ The link label MUST be the bare repository name (e.g. `baselibs`,
157170
| **PA5** Unit Tests | repo has `_test.cpp` / `_test.py` / `tests/` || none |
158171
| **PA5** C0/C1 Coverage | C0 = C1 = 100 % | data exists (any %) | not in `reference_integration` CI |
159172
| **PA5** Comp. Integration Tests | tests in module's own repo || none |
160-
| **PA5** Static Analysis | zero-tolerance per-module CI workflow passes on `main` (clang-tidy / Clippy) | tools configured but no CI enforcement | no static-analysis config | _no link_ — Static cells render the **status only**, no source-code link. Same convention as Dynamic Analysis (§4.2). |
173+
| **PA5** Static Analysis | zero-tolerance per-module CI workflow passes on `main` (clang-tidy / Clippy) | tools configured but no CI enforcement | no static-analysis config |
161174
| **PA5** Dynamic Analysis | zero-tolerance sanitizer CI passes on `main` || no sanitizer CI |
162175
| **PA5** Module Ver. Report | `verification/module_verification_report.rst` `:status: valid` and contains data | `:status: draft` | absent or template only |
163176
| **PA5** Platform Ver. Report | _no column_ — the platform verification report exists **once** for the entire platform; do not render it as a per-module column. Add it as a **bold one-liner immediately after the PA5 table** (see §5.2). | | |
164177

178+
> **Static / Dynamic Analysis cells render the status only, no source-code
179+
> link.** The PA5 link discipline of §5.2 does not apply to these two
180+
> columns: there is no canonical per-module artefact to point at (CI
181+
> workflows live in the org-wide `.github` repo, not per module).
182+
165183
### 4.0 PA1 — Feature Request issue lookup
166184

167185
PA1 "CR approved" tracks **Feature Request** issues in `eclipse-score/score`.

0 commit comments

Comments
 (0)