logging: address review comments

ShivamPatidar24 · rmaddikery · ShivamPatidar24 · commit 9f49a989ae12 · 2026-07-09T15:45:32.000+05:30
Co-authored-by: Raghavendra Maddikery &lt;raghav.maddikery@gmail.com&gt;
Signed-off-by: Cvam7 &lt;108720572+ShivamPatidar24@users.noreply.github.com&gt;
diff --git a/MODULE.bazel.lock b/MODULE.bazel.lock
diff --git a/bazel_common/score_modules_target_sw.MODULE.bazel b/bazel_common/score_modules_target_sw.MODULE.bazel
@@ -17,7 +17,7 @@
 bazel_dep(name = "score_baselibs")
 git_override(
     module_name = "score_baselibs",
-    commit = "cab36dd7de92c282f67e78e88032e08585803528",
+    commit = "ac3eb431b05ec37a5c346a6230c62e35dfbd8884",
     remote = "https://github.com/eclipse-score/baselibs.git",
 )
 
@@ -72,11 +72,11 @@ git_override(
 bazel_dep(name = "score_logging")
 git_override(
     module_name = "score_logging",
-    commit = "3da15793ed76bc8b97cffe379345f3c3d61c17cd",
+    commit = "9faad72199cbc2259b1fe4d712c5c769cdfd954e",
     patch_strip = 1,
     patches = [
         "//patches/logging:001-logging-example-visibility.patch",
-        "//patches/logging:002-deps-visibility.patch",
+        "//patches/logging:002-rules-pkg-dependency.patch",
     ],
     remote = "https://github.com/eclipse-score/logging.git",
 )
diff --git a/feature_integration_tests/itf/test_remote_logging.py b/feature_integration_tests/itf/test_remote_logging.py
@@ -27,9 +27,8 @@
 CAPTURE_DURATION_SECONDS = 10
 
 # DLT message identifiers for datarouter statistics
-
-APP_ID = "EXA"
-CTX_ID = "DFLT"
+APP_ID = "DR"
+CTX_ID = "STAT"
 
 _QNX_DATAROUTER_CHECK_CMD = "/proc/boot/pidin | /proc/boot/grep datarouter"
 _LINUX_DATAROUTER_CHECK_CMD = "ps -ef | grep datarouter | grep -v grep"
@@ -41,9 +40,6 @@
     "./datarouter --no_adaptive_runtime > /dev/null 2>&1 &"
 )
 _LINUX_DATAROUTER_START_CMD = "cd /usr/bin/datarouter && nohup ./datarouter --no_adaptive_runtime > /dev/null 2>&1 &"
-
-
-_LOGGINGAPP_START_CMD = "cd /showcases/data/logging/logging_app/etc && nohup /showcases/bin/logging_app &"
 # Multicast route directs all multicast traffic (224.0.0.0/4) out of the containers
 # network interface required for DLT messages to reach the host via the Docker bridge.
 _LINUX_CHECK_MULTICAST_ROUTE_CMD = "ip route add 224.0.0.0/4 dev eth0 2>/dev/null || true"
@@ -89,7 +85,7 @@ def datarouter_running(target):
     yield
 
 
-def test_remote_logging(datarouter_running, target, dlt_config):
+def test_remote_logging(datarouter_running, dlt_config):
     """Verifies remote logging of Dataraouter
 
     Starts Datarouter on the target if not already running, then
@@ -104,10 +100,6 @@ def test_remote_logging(datarouter_running, target, dlt_config):
         print_to_stdout=True,
         binary_path=dlt_config.dlt_receive_path,
     ) as window:
-        logger.info("Starting logging app to generate DLT messages..")
-        exit_code, out = target.execute(_LOGGINGAPP_START_CMD)
-        logger.debug("Logging app start command exit_code=%s", exit_code)
-
         time.sleep(CAPTURE_DURATION_SECONDS)
 
     record = window.record(filters=[(APP_ID, CTX_ID)])
@@ -119,3 +111,46 @@ def test_remote_logging(datarouter_running, target, dlt_config):
     assert message_count > 1, (
         f"Expected atleast one DLT message with app_id: {APP_ID} and context_id: {CTX_ID}, but got {message_count}"
     )
+
+
+# DLT message identifiers for the Logging App
+LOGGING_APP_ID = "EXA"
+LOGGING_CTX_ID = "DFLT"
+
+_LOGGINGAPP_START_CMD = "cd /showcases/data/logging/logging_app/etc && nohup /showcases/bin/logging_app &"
+
+
+def test_logging_app_logs_forwarded_to_dlt(datarouter_running, target, dlt_config):
+    """Verifies that Logging App logs are forwarded to DLT."""
+
+    with DltWindow(
+        protocol=Protocol.UDP,
+        host_ip=dlt_config.host_ip,
+        multicast_ips=dlt_config.multicast_ips,
+        print_to_stdout=True,
+        binary_path=dlt_config.dlt_receive_path,
+    ) as window:
+        logger.info("Starting logging_app...")
+        exit_code, out = target.execute(_LOGGINGAPP_START_CMD)
+
+        logger.info("logging_app start exit_code=%s", exit_code)
+        logger.info(out.decode(errors="replace"))
+
+        assert exit_code == 0, "Failed to start logging_app"
+
+        time.sleep(CAPTURE_DURATION_SECONDS)
+
+    record = window.record(filters=[(LOGGING_APP_ID, LOGGING_CTX_ID)])
+    messages = record.find(query=dict(apid=LOGGING_APP_ID, ctid=LOGGING_CTX_ID))
+
+    logger.debug(
+        "Found %d messages with app_id=%s, context_id=%s",
+        len(messages),
+        LOGGING_APP_ID,
+        LOGGING_CTX_ID,
+    )
+
+    assert len(messages) > 0, (
+        f"Expected at least one DLT message with app_id={LOGGING_APP_ID} "
+        f"and context_id={LOGGING_CTX_ID}, but got {len(messages)}"
+    )
diff --git a/known_good.json b/known_good.json
@@ -3,7 +3,7 @@
         "target_sw": {
             "score_baselibs": {
                 "repo": "https://github.com/eclipse-score/baselibs.git",
-                "hash": "cab36dd7de92c282f67e78e88032e08585803528",
+                "hash": "ac3eb431b05ec37a5c346a6230c62e35dfbd8884",
                 "metadata": {
                     "extra_test_config": [
                         "@score_baselibs//score/json:base_library=nlohmann",
@@ -97,10 +97,10 @@
             },
             "score_logging": {
                 "repo": "https://github.com/eclipse-score/logging.git",
-                "hash": "3da15793ed76bc8b97cffe379345f3c3d61c17cd",
+                "hash": "9faad72199cbc2259b1fe4d712c5c769cdfd954e",
                 "bazel_patches": [
                     "//patches/logging:001-logging-example-visibility.patch",
-                    "//patches/logging:002-deps-visibility.patch"],
+                    "//patches/logging:002-rules-pkg-dependency.patch"],
                 "metadata": {
                     "code_root_path": "//score/mw/...",
                     "extra_test_config": [
diff --git a/patches/logging/002-rules-pkg-dependency.patch b/patches/logging/002-rules-pkg-dependency.patch
diff --git a/showcases/README.md b/showcases/README.md
@@ -1,7 +1,7 @@
-# Logging Example
+# Logging App Demo
  
-This example demonstrates logging with all log levels via Console Logging and Remote Logging.
+This Logging App demonstrates logging using mw::log with all log levels and configured backends (kConsole|kRemote|kFile) enabled.
 
-For remote logging details, refer to the following documentation:
+For remote (DLT) logging, please refer to the following documentation:
  
 [Remote logging](https://github.com/eclipse-score/logging/blob/main/score/datarouter/doc/guideline/dlt_capture_demo.md)
diff --git a/showcases/standalone/logging.score.json b/showcases/standalone/logging.score.json
@@ -1,6 +1,6 @@
 {
-    "name": "Logging example",
-    "description": "Example for running logging with all log levels via remote and console",
+    "name": "LoggingApp Demo",
+    "description": "A Logging app that demonstrates logging with mw::log with kConsole|kRemote|kFile config.",
     "apps": [
       {
         "path": "/bin/sh",

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`		`- "name": "Logging example",`
`3`		`- "description": "Example for running logging with all log levels via remote and console",`
	`2`	`+ "name": "LoggingApp Demo",`
	`3`	`+ "description": "A Logging app that demonstrates logging with mw::log with kConsole\|kRemote\|kFile config.",`
`4`	`4`	`"apps": [`
`5`	`5`	`{`
`6`	`6`	`"path": "/bin/sh",`