Skip to content

Commit 0160d13

Browse files
committed
bazel: Solve grpc-java problem
flatbuffers depends on an older grpc-java version, which breaks the `bazel mod deps` command. The easiest way is to depend on the version with the fix, eventhough we have no other direct dependency. This way, the bigger version gets selected. In addition, we ensure that this will not break again.
1 parent 0f71546 commit 0160d13

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/tests.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,3 +54,6 @@ jobs:
5454
- name: Run Validation Tooling tests
5555
run: |
5656
bazel test //validation/...
57+
- name: Ensure correct dependency resolution
58+
run: |
59+
bazel mod deps --lockfile_mode=update

MODULE.bazel

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,11 @@ bazel_dep(name = "bazel_skylib", version = "1.7.1")
3434
bazel_dep(name = "buildifier_prebuilt", version = "8.2.0.2")
3535
bazel_dep(name = "flatbuffers", version = "25.9.23")
3636

37+
# flatbuffers depends on this transitively, but older grpc-java version
38+
# The main problem is that there the command `bazel mod deps` is broken, which
39+
# we want and need to support for dependant modules
40+
bazel_dep(name = "grpc-java", version = "1.75.0.bcr.1")
41+
3742
###############################################################################
3843
# CC Toolchain
3944
###############################################################################

0 commit comments

Comments
 (0)