Skip to content

Commit 738a563

Browse files
invincibleXiaobaohoe-jo
authored andcommitted
fix review items
1 parent c45d942 commit 738a563

21 files changed

Lines changed: 658 additions & 1087 deletions

File tree

plantuml/parser/integration_test/activity_diagram/parser/action_separated/output.json

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,17 +4,29 @@
44
"statements": [
55
{
66
"Action": {
7-
"label": "A1"
7+
"label": "A1",
8+
"source": {
9+
"start_line": 15,
10+
"start_column": 1
11+
}
812
}
913
},
1014
{
1115
"Action": {
12-
"label": "A2"
16+
"label": "A2",
17+
"source": {
18+
"start_line": 16,
19+
"start_column": 1
20+
}
1321
}
1422
},
1523
{
1624
"Action": {
17-
"label": "A3"
25+
"label": "A3",
26+
"source": {
27+
"start_line": 17,
28+
"start_column": 1
29+
}
1830
}
1931
}
2032
]

plantuml/parser/integration_test/activity_diagram/parser/action_simple/output.json

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,20 @@
44
"statements": [
55
{
66
"Action": {
7-
"label": "Hello activity diagram"
7+
"label": "Hello activity diagram",
8+
"source": {
9+
"start_line": 15,
10+
"start_column": 1
11+
}
812
}
913
},
1014
{
1115
"Action": {
12-
"label": "This block is defined on\nseveral lines"
16+
"label": "This block is defined on\nseveral lines",
17+
"source": {
18+
"start_line": 16,
19+
"start_column": 1
20+
}
1321
}
1422
}
1523
]

plantuml/parser/integration_test/activity_diagram/parser/arrows/output.json

Lines changed: 66 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -4,71 +4,124 @@
44
"statements": [
55
{
66
"Action": {
7-
"label": "foo1"
7+
"label": "foo1",
8+
"source": {
9+
"start_line": 15,
10+
"start_column": 1
11+
}
812
}
913
},
1014
{
1115
"Arrow": {
1216
"syntax": "->",
13-
"label": "You can put text on arrows"
17+
"label": "You can put text on arrows",
18+
"source": {
19+
"start_line": 16,
20+
"start_column": 1
21+
}
1422
}
1523
},
1624
{
1725
"IfStart": {
1826
"condition": "test",
19-
"label": null
27+
"label": null,
28+
"source": {
29+
"start_line": 17,
30+
"start_column": 1
31+
}
2032
}
2133
},
2234
{
2335
"Arrow": {
2436
"syntax": "-[#blue]->",
25-
"label": null
37+
"label": null,
38+
"source": {
39+
"start_line": 18,
40+
"start_column": 3
41+
}
2642
}
2743
},
2844
{
2945
"Action": {
30-
"label": "foo2"
46+
"label": "foo2",
47+
"source": {
48+
"start_line": 19,
49+
"start_column": 3
50+
}
3151
}
3252
},
3353
{
3454
"Arrow": {
3555
"syntax": "-[#green,dashed]->",
36-
"label": "The text can\nalso be on several lines\nand very long..."
56+
"label": "The text can\nalso be on several lines\nand very long...",
57+
"source": {
58+
"start_line": 20,
59+
"start_column": 3
60+
}
3761
}
3862
},
3963
{
4064
"Action": {
41-
"label": "foo3"
65+
"label": "foo3",
66+
"source": {
67+
"start_line": 23,
68+
"start_column": 3
69+
}
4270
}
4371
},
4472
{
4573
"Else": {
46-
"label": null
74+
"label": null,
75+
"source": {
76+
"start_line": 24,
77+
"start_column": 1
78+
}
4779
}
4880
},
4981
{
5082
"Arrow": {
5183
"syntax": "-[#black,dotted]->",
52-
"label": null
84+
"label": null,
85+
"source": {
86+
"start_line": 25,
87+
"start_column": 3
88+
}
5389
}
5490
},
5591
{
5692
"Action": {
57-
"label": "foo4"
93+
"label": "foo4",
94+
"source": {
95+
"start_line": 26,
96+
"start_column": 3
97+
}
5898
}
5999
},
60100
{
61-
"EndIf": null
101+
"EndIf": {
102+
"source": {
103+
"start_line": 27,
104+
"start_column": 1
105+
}
106+
}
62107
},
63108
{
64109
"Arrow": {
65110
"syntax": "-[#gray,bold]->",
66-
"label": null
111+
"label": null,
112+
"source": {
113+
"start_line": 28,
114+
"start_column": 1
115+
}
67116
}
68117
},
69118
{
70119
"Action": {
71-
"label": "foo5"
120+
"label": "foo5",
121+
"source": {
122+
"start_line": 29,
123+
"start_column": 1
124+
}
72125
}
73126
}
74127
]

plantuml/parser/integration_test/activity_diagram/parser/color/output.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,11 @@
44
"statements": [
55
{
66
"Action": {
7-
"label": "Hello Activity Diagram"
7+
"label": "Hello Activity Diagram",
8+
"source": {
9+
"start_line": 15,
10+
"start_column": 1
11+
}
812
}
913
}
1014
]

plantuml/parser/integration_test/activity_diagram/parser/fork/output.json

Lines changed: 67 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,51 +3,106 @@
33
"name": "fork",
44
"statements": [
55
{
6-
"Start": null
6+
"Start": {
7+
"source": {
8+
"start_line": 15,
9+
"start_column": 1
10+
}
11+
}
712
},
813
{
9-
"ForkStart": null
14+
"ForkStart": {
15+
"source": {
16+
"start_line": 16,
17+
"start_column": 1
18+
}
19+
}
1020
},
1121
{
1222
"Action": {
13-
"label": "A"
23+
"label": "A",
24+
"source": {
25+
"start_line": 17,
26+
"start_column": 3
27+
}
1428
}
1529
},
1630
{
17-
"ForkAgain": null
31+
"ForkAgain": {
32+
"source": {
33+
"start_line": 18,
34+
"start_column": 1
35+
}
36+
}
1837
},
1938
{
2039
"Action": {
21-
"label": "B"
40+
"label": "B",
41+
"source": {
42+
"start_line": 19,
43+
"start_column": 3
44+
}
2245
}
2346
},
2447
{
25-
"Stop": null
48+
"Stop": {
49+
"source": {
50+
"start_line": 20,
51+
"start_column": 3
52+
}
53+
}
2654
},
2755
{
28-
"ForkAgain": null
56+
"ForkAgain": {
57+
"source": {
58+
"start_line": 21,
59+
"start_column": 1
60+
}
61+
}
2962
},
3063
{
3164
"Action": {
32-
"label": "C"
65+
"label": "C",
66+
"source": {
67+
"start_line": 22,
68+
"start_column": 3
69+
}
3370
}
3471
},
3572
{
36-
"ForkAgain": null
73+
"ForkAgain": {
74+
"source": {
75+
"start_line": 23,
76+
"start_column": 1
77+
}
78+
}
3779
},
3880
{
3981
"Action": {
40-
"label": "D"
82+
"label": "D",
83+
"source": {
84+
"start_line": 24,
85+
"start_column": 3
86+
}
4187
}
4288
},
4389
{
4490
"ForkEnd": {
4591
"kind": "EndFork",
46-
"modifier": null
92+
"modifier": null,
93+
"source": {
94+
"start_line": 25,
95+
"start_column": 1
96+
}
4797
}
4898
},
4999
{
50-
"Stop": null
100+
"Stop": {
101+
"source": {
102+
"start_line": 26,
103+
"start_column": 1
104+
}
105+
}
51106
}
52107
]
53108
}

0 commit comments

Comments
 (0)