Skip to content

Commit 86b0a6b

Browse files
hoe-jocastler
authored andcommitted
[plantuml parser]: fix silently succeeding on parsing errors
1 parent 6e849be commit 86b0a6b

1 file changed

Lines changed: 3 additions & 14 deletions

File tree

  • plantuml/parser/puml_cli/src

plantuml/parser/puml_cli/src/main.rs

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
use clap::{ArgGroup, Parser, ValueEnum};
1515
use env_logger::Builder;
16-
use log::{debug, error, warn};
16+
use log::debug;
1717
use serde::Serialize;
1818
use std::collections::HashMap;
1919
use std::collections::HashSet;
@@ -29,7 +29,7 @@ use puml_resolver::{
2929
ClassResolver, ComponentResolver, DiagramResolver, SequenceResolver, SequenceTree,
3030
};
3131
use puml_serializer::{ClassSerializer, ComponentSerializer};
32-
use puml_utils::{write_fbs_to_file, write_json_to_file, write_placeholder_file, LogLevel};
32+
use puml_utils::{write_fbs_to_file, write_json_to_file, LogLevel};
3333

3434
/// CLI wrapper for LogLevel that implements ValueEnum
3535
#[derive(Copy, Clone, ValueEnum, Debug)]
@@ -193,18 +193,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
193193
}
194194
}
195195
Err(e) => {
196-
error!("Resolve error in {}: {}", path.display(), e);
197-
warn!(
198-
"Skipping file due to unimplemented diagram type: {}",
199-
path.display()
200-
);
201-
// Create empty placeholder files so the build continues
202-
if let Some(ref dir) = fbs_output_dir {
203-
write_placeholder_file(path, dir)?;
204-
}
205-
if let Some(ref ldir) = lobster_output_dir {
206-
write_lobster_to_file(LobsterModel::Empty, path, ldir)?;
207-
}
196+
return Err(format!("Resolve error in {}: {}", path.display(), e).into());
208197
}
209198
}
210199
}

0 commit comments

Comments
 (0)