Clippy fix and add CI workflows

Author: melodyoncode

.github/workflows/tests.yml

@@ -57,3 +57,9 @@ jobs:
       - name: Ensure correct dependency resolution
         run: |
           bazel mod deps --lockfile_mode=update
+      - name: Run Libclang Parser Tooling clippy
+        run: |
+          bazel build //cpp/libclang/... --config=clippy
+      - name: Run Libclang Parser Tooling tests
+        run: |
+          bazel test //cpp/libclang/...

cpp/libclang/README.md

@@ -1,3 +1,16 @@
+<!-- ----------------------------------------------------------------------------
+  Copyright (c) 2026 Contributors to the Eclipse Foundation
+
+  See the NOTICE file(s) distributed with this work for additional
+  information regarding copyright ownership.
+
+  This program and the accompanying materials are made available under the
+  terms of the Apache License Version 2.0 which is available at
+  https://www.apache.org/licenses/LICENSE-2.0
+
+  SPDX-License-Identifier: Apache-2.0
+----------------------------------------------------------------------------- -->
+
 # Run C++ parser targets
 
 ## Configure a parser target in `BUILD`

cpp/libclang/integration_test/README.md

@@ -1,3 +1,16 @@
+<!-- ----------------------------------------------------------------------------
+  Copyright (c) 2026 Contributors to the Eclipse Foundation
+
+  See the NOTICE file(s) distributed with this work for additional
+  information regarding copyright ownership.
+
+  This program and the accompanying materials are made available under the
+  terms of the Apache License Version 2.0 which is available at
+  https://www.apache.org/licenses/LICENSE-2.0
+
+  SPDX-License-Identifier: Apache-2.0
+----------------------------------------------------------------------------- -->
+
 # libclang Integration Tests
 
 This directory contains integration tests for the C++ libclang parser and related tooling.

cpp/libclang/src/main.rs

@@ -49,7 +49,7 @@ struct Args {
 
 fn parse_file(
     file: &PathBuf,
-    compilation_flags: &Vec<String>,
+    compilation_flags: &[String],
     index: &clang::Index,
     ast_file_output_path: &PathBuf,
     all_classes: &mut BTreeMap<String, context::TypeMapValue>,
@@ -64,7 +64,7 @@ fn parse_file(
         }
     };
 
-    let parse_result = index.parser(&file).arguments(&compilation_flags).parse();
+    let parse_result = index.parser(file).arguments(compilation_flags).parse();
 
     match parse_result {
         Ok(parsed) => {
@@ -76,7 +76,7 @@ fn parse_file(
             }
 
             let entity = parsed.get_entity();
-            print_entity(&entity, 0, PrintMode::File(&ast_file_output_path));
+            print_entity(&entity, 0, PrintMode::File(ast_file_output_path));
             print_entity(&entity, 0, PrintMode::Stdout);
 
             let mut ctx = VisitContext::default();
@@ -139,8 +139,8 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
         let compilation_flags = &command_line_args.extra_args;
 
         parse_file(
-            &file,
-            &compilation_flags,
+            file,
+            compilation_flags,
             &index,
             &ast_file_output_path,
             &mut all_classes,

cpp/libclang/src/visitor/src/class_parser_helper.rs

@@ -10,6 +10,8 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 ////////////////////////////////////////////////////////////////////////////////////
+#![cfg_attr(test, allow(dead_code))]
+
 use clang::{Entity, EntityKind, Type, TypeKind};
 use serde::{Deserialize, Serialize};
 
@@ -450,7 +452,7 @@ fn resolve_unqualified_type(original: &Type, canonical: &Type) -> ResolvedType {
 
             ResolvedType::Array {
                 element: Box::new(element),
-                size: original.get_size().map(|s| s as usize),
+                size: original.get_size(),
             }
         }
 
@@ -624,7 +626,7 @@ fn build_fqn_from_entity(entity: &Entity) -> String {
     // Traversal is semantic (not lexical) so aliases/nested constructs resolve to
     // stable ownership hierarchy used by relationship and id matching.
     let mut parts: Vec<(String, bool)> = Vec::new();
-    let mut current = Some(entity.clone());
+    let mut current = Some(*entity);
 
     while let Some(entity) = current {
         match entity.get_kind() {

cpp/libclang/src/visitor/src/class_visitor.rs

@@ -74,7 +74,7 @@ impl ClassVisitor {
         };
 
         let mut class_entity = SimpleEntity {
-            id: id,
+            id,
             name: name.clone(),
             enclosing_namespace_id: namespace.map(|ns| ns.to_string()),
             ..Default::default()
@@ -153,12 +153,8 @@ fn parse_source_location(entity: &Entity) -> (Option<String>, Option<u32>) {
 }
 
 fn collect_variable_type(entity: &Entity) -> Option<ParsedVariableType> {
-    let Some(name) = entity.get_name() else {
-        return None;
-    };
-    let Some(field_type) = entity.get_type() else {
-        return None;
-    };
+    let name = entity.get_name()?;
+    let field_type = entity.get_type()?;
 
     Some(ParsedVariableType {
         name,

cpp/libclang/src/visitor/src/context.rs

@@ -14,7 +14,7 @@ use serde::{Deserialize, Serialize};
 use std::collections::HashMap;
 
 pub use class_diagram::SimpleEntity;
-use sequence_diagram::FunctionDef;
+use sequence_logic::FunctionDef;
 
 use crate::class_parser_helper::ResolvedType;
 

cpp/libclang/src/visitor/src/enum_visitor.rs

@@ -36,7 +36,7 @@ impl EnumVisitor {
         };
         Some(SimpleEntity {
             id: full_qualified_id,
-            name: name,
+            name,
             enclosing_namespace_id: namespace_id,
             entity_type: EntityType::Enum,
             enum_literals: get_literals(entity),

cpp/libclang/src/visitor/src/function_visitor.rs

@@ -18,7 +18,7 @@
 
 use crate::{context::VisitContext, AstVisitor};
 use clang::{Entity, EntityKind};
-use sequence_diagram::{BodyItem, FunctionDef};
+use sequence_logic::{BodyItem, FunctionDef};
 
 pub struct FunctionVisitor;
 

cpp/libclang/src/visitor/src/lib.rs

@@ -22,6 +22,6 @@ pub use class_visitor::ClassVisitor;
 pub use context::VisitContext;
 pub use enum_visitor::EnumVisitor;
 pub use function_visitor::FunctionVisitor;
-pub use sequence_diagram::{BodyItem, FunctionDef};
+pub use sequence_logic::{BodyItem, FunctionDef};
 pub use visitor::AstVisitor;
 pub use visitor::Visitor;