[rules score] fix tests

- execute Rules Score Tests from Test Module in CI
- Fix Test Module dependencies
- Fix Failing Tests

Author: hoe-jo

.bazelignore

@@ -13,3 +13,5 @@
 
 python_basics/integration_tests
 starpls/integration_tests
+# Should be run from its own directory (separate Module)
+bazel/rules/rules_score/test

.github/copilot-instructions.md

@@ -0,0 +1,105 @@
+<!--
+Copyright (c) 2026 Contributors to the Eclipse Foundation
+
+SPDX-License-Identifier: Apache-2.0
+-->
+
+# Score Tooling — Agent Instructions
+
+**Score Tooling** is a unified Bazel module (`score_tooling`) providing development tools for building, testing, and maintaining code quality. All public macros are re-exported from [defs.bzl](../defs.bzl).
+
+## Modules
+
+| Module | Language | Purpose | Docs |
+|--------|----------|---------|------|
+| `python_basics` | Starlark/Python | `score_py_pytest` + `score_virtualenv` macros | [README](../python_basics/README.md) |
+| `cr_checker` | Python | Copyright header checker/fixer | [README](../cr_checker/README.md) |
+| `dash` | Tool | DASH license compliance | [README](../dash/README.md) |
+| `format_checker` | Starlark | `use_format_targets()` → `:format.fix` / `:format.check` | [README](../format_checker/README.md) |
+| `cli_helper` | Starlark | CLI helper Bazel rule | [README](../cli_helper/README.md) |
+| `starpls` | Config | Starlark language server | [README](../starpls/README.md) |
+| `coverage` | Shell+Bazel | Combined Rust+Python coverage → HTML | [README](../coverage/README.md) |
+| `lobster_bazel` | Python | Extracts traceability tags for LOBSTER | [README](../lobster_bazel/README.md) |
+| `manual_analysis` | Python+Starlark | Interactive manual verification workflow | [README](../manual_analysis/README.md) |
+| `plantuml` | Rust | PlantUML FTA-metamodel parser | [README](../plantuml/parser/README.md) |
+| `validation` | Rust+Python | Bazel-graph vs. PlantUML validation + AI checker | [README](../validation/ai_checker/README.md) |
+| `tools` | Config | Multitool lockfile: ruff, shellcheck, actionlint, yamlfmt | [README](../tools/README.md) |
+
+## Build & Test Commands
+
+```bash
+bazel test //...                           # all tests
+bazel test //:format.check                 # check formatting (ruff, buildifier, rustfmt, yamlfmt)
+bazel run  //:format.fix                   # auto-fix formatting
+bazel run  //:copyright.check              # check copyright headers
+
+# Rust-specific
+bazel build //plantuml/... --config=clippy
+bazel build //validation/... --config=clippy
+
+# Coverage
+bazel run //coverage:combined_report
+
+# IDE virtualenv
+bazel run //:ide_support                   # creates .venv
+
+# AI checker (runs at test time; inherits Copilot credentials from your shell)
+bazel test //path/to:my_ai_check
+```
+
+**Integration tests** have their own `MODULE.bazel` — run from their subdirectory:
+
+```bash
+cd python_basics/integration_tests && bazel test //...
+cd starpls/integration_tests && bazel test //...
+```
+
+## Critical Conventions
+
+### Copyright header — mandatory on every file
+Every `.py`, `.bzl`, `.rs`, `.sh`, `.cpp` file must begin with:
+```
+# Copyright (c) <year> Contributors to the Eclipse Foundation
+#
+# SPDX-License-Identifier: Apache-2.0
+```
+The `:copyright.check` target enforces this and will fail CI if missing.
+
+### Python
+- Version: **3.12** (pinned in `MODULE.bazel` + `python_basics/pyproject.toml`)
+- Linter: **ruff** (`E, F, I, B, C90, UP, SIM, RET` rules)
+- Type checker: **basedpyright** (`standard` mode)
+- All Python tests must use `score_py_pytest`, not raw `py_test`
+- `--incompatible_default_to_explicit_init_py` is active — no automatic `__init__.py`
+
+### Bazel/Starlark
+- Formatting: **buildifier**
+- Bzlmod (`MODULE.bazel`) is primary; `deps.bzl` is legacy compat only
+- Root `BUILD` registers `:copyright.check`, `:format.check`, `:format.fix` targets
+
+### Rust
+- Edition 2021; rustfmt + clippy via `--config=clippy`
+
+## Dependency / Requirements Management
+
+Each sub-package has its own pip hub with `requirements.in` → `requirements.txt`:
+
+| Hub | Lock file |
+|-----|-----------|
+| `pip_tooling` | `python_basics/requirements.txt` |
+| `pip_lobster_bazel` | `lobster_bazel/requirements.txt` |
+| `manual_analysis_deps` | `manual_analysis/requirements.txt` |
+| `pip_validation_ai_checker` | `validation/ai_checker/requirements.txt` |
+
+After editing `requirements.in`, regenerate with:
+```bash
+bazel run //<pkg>:requirements.update
+```
+Both `requirements.in` and `requirements.txt` are committed to VCS.
+
+## Common Pitfalls
+
+- **AI checker tests need `tags = ["manual"]`** — otherwise `bazel test //...` attempts to run them without Copilot credentials.
+- **`lobster_bazel` traceability tags** must be at the start of a line (not inline).
+- **Format check fails silently** if buildifier or ruff versions are out of sync with the multitool lockfile in `tools/`.
+- **`manual_analysis` lock files are committed** — always run `{target}.update` after changing analysis YAML, then commit the updated lock.

.github/workflows/tests.yml

@@ -41,7 +41,8 @@ jobs:
           bazel test //coverage/tests:all
       - name: Run rules_score tests
         run: |
-          bazel test //bazel/rules/rules_score/...
+          cd bazel/rules/rules_score/test
+          bazel test //...
       - name: Run Plantuml Tooling clippy
         run: |
           bazel build //plantuml/... --config=clippy

bazel/rules/rules_score/test/BUILD

@@ -1,3 +1,5 @@
+load("@aspect_rules_py//py:defs.bzl", "py_binary")
+
 # *******************************************************************************
 # Copyright (c) 2025 Contributors to the Eclipse Foundation
 #
@@ -26,6 +28,7 @@ load(
     "unit",
     "unit_design",
 )
+load("@score_tooling//bazel/rules/rules_score:sphinx_toolchain.bzl", "sphinx_toolchain")
 load("@trlc//:trlc.bzl", "trlc_requirements", "trlc_requirements_test")
 load(
     ":html_generation_test.bzl",
@@ -93,6 +96,38 @@ load(
 
 package(default_visibility = ["//visibility:public"])
 
+# ============================================================================
+# Sphinx Toolchain — uses score_docs_as_code so score_metamodel is importable
+# ============================================================================
+
+exports_files(["template/conf.template.py"])
+
+py_binary(
+    name = "score_build",
+    srcs = ["@score_tooling//bazel/rules/rules_score:src/sphinx_wrapper.py"],
+    main = "@score_tooling//bazel/rules/rules_score:src/sphinx_wrapper.py",
+    package_collisions = "warning",
+    visibility = ["//visibility:public"],
+    deps = [
+        "@score_docs_as_code//src:plantuml_for_python",
+        "@score_docs_as_code//src/extensions/score_sphinx_bundle",
+        "@score_tooling//bazel/rules/rules_score:bazel_sphinx_needs",
+        "@score_tooling//bazel/rules/rules_score:sphinx_module_ext",
+    ],
+)
+
+sphinx_toolchain(
+    name = "score_sphinx_toolchain",
+    conf_template = "//:template/conf.template.py",
+    sphinx = ":score_build",
+)
+
+toolchain(
+    name = "score_toolchain",
+    toolchain = ":score_sphinx_toolchain",
+    toolchain_type = "@score_tooling//bazel/rules/rules_score:toolchain_type",
+)
+
 # ============================================================================
 # Test Fixtures - Module Definitions
 # ============================================================================
@@ -274,7 +309,7 @@ unit_design(
 unit(
     name = "test_unit",
     testonly = True,
-    scope = ["//bazel/rules/rules_score/test:mock_lib1"],
+    scope = ["//:mock_lib1"],
     tests = [":test_unit_tests"],
     unit_design = [":test_unit_design"],
     implementation = [
@@ -700,26 +735,11 @@ aous_rst_sphinx_test(
 requirements_rst_test_suite(name = "requirements_rst_tests")
 
 # ============================================================================
-# Image srcs Tests
+# Image srcs Tests (defined in sub-package to avoid workspace-root edge case)
 # ============================================================================
-
-# Fixture: feature_requirements with image_srcs
-feature_requirements(
-    name = "feat_req_with_image",
-    srcs = ["fixtures/seooc_test/feature_requirements.trlc"],
-    image_srcs = [
-        "fixtures/image_srcs/diagrams/arch.svg",
-        "fixtures/image_srcs/diagrams/arch.png",
-    ],
-    deps = [":asr_trlc"],
-)
-
-image_srcs_sphinx_sources_test(
-    name = "image_srcs_sphinx_sources_test",
-    target_under_test = ":feat_req_with_image",
-)
-
-requirements_image_test_suite(name = "requirements_image_tests")
+# feat_req_with_image and image_srcs_sphinx_sources_test live in
+# //fixtures/image_srcs so that ctx.label.package is non-empty and
+# subrule_trlc_image_stage can strip the prefix correctly.
 
 # ============================================================================
 # Combined Test Suite
@@ -736,7 +756,7 @@ requirements_image_test_suite(name = "requirements_image_tests")
 trlc_requirements(
     name = "safety_measures_fixtures",
     srcs = ["fixtures/seooc_test/safety_measures_fixtures.trlc"],
-    spec = ["//bazel/rules/rules_score/trlc/config:score_requirements_model"],
+    spec = ["@score_tooling//bazel/rules/rules_score/trlc/config:score_requirements_model"],
 )
 
 trlc_requirements_test(
@@ -748,22 +768,22 @@ py_test(
     name = "test_safety_analysis_tools",
     size = "small",
     srcs = ["test_safety_analysis_tools.py"],
-    deps = ["//bazel/rules/rules_score:safety_analysis_tools"],
+    deps = ["@score_tooling//bazel/rules/rules_score:safety_analysis_tools"],
 )
 
 py_test(
     name = "test_aou_forwarding_to_lobster",
     size = "small",
     srcs = ["test_aou_forwarding_to_lobster.py"],
-    deps = ["//bazel/rules/rules_score:aou_forwarding_to_lobster"],
+    deps = ["@score_tooling//bazel/rules/rules_score:aou_forwarding_to_lobster"],
 )
 
 py_test(
     name = "test_rst_to_trlc",
     size = "small",
     srcs = ["rst_to_trlc_test.py"],
     main = "rst_to_trlc_test.py",
-    deps = ["//bazel/rules/rules_score:rst_to_trlc_lib"],
+    deps = ["@score_tooling//bazel/rules/rules_score:rst_to_trlc_lib"],
 )
 
 py_test(
@@ -782,7 +802,6 @@ py_test(
 test_suite(
     name = "all_tests",
     tests = [
-        ":requirements_image_tests",
         ":requirements_rst_tests",
         ":seooc_tests",
         ":sphinx_module_tests",
@@ -791,5 +810,6 @@ test_suite(
         ":test_safety_analysis_tools",
         ":test_trlc_rst_image_rendering",
         ":unit_component_tests",
+        "//fixtures/image_srcs:requirements_image_tests",
     ],
 )

bazel/rules/rules_score/test/MODULE.bazel

@@ -55,6 +55,8 @@ pip.parse(
 use_repo(pip, "pip_tooling_test")
 
 bazel_dep(name = "score_docs_as_code", version = "3.0.1", dev_dependency = True)
+
+bazel_dep(name = "googletest", version = "1.17.0.bcr.2")
 # bazel_dep(name = "score_platform", version = "0.5.0")
 # bazel_dep(name = "score_process", version = "1.3.2")
 
@@ -71,13 +73,13 @@ register_toolchains(
 bazel_dep(name = "trlc", version = "0.0.0")
 git_override(
     module_name = "trlc",
-    commit = "7f06d0396fd0e5f02b657d25700775af5113b7e0",
+    commit = "c4c531b9d667085daa09dfc1590edacc314bfda4",
     remote = "https://github.com/bmw-software-engineering/trlc.git",
 )
 
 bazel_dep(name = "lobster", version = "0.0.0")
 git_override(
     module_name = "lobster",
-    commit = "56881461f9d3fde2918d1731aa5937aaf64cd67c",
+    commit = "2792e2daee2cf524fdc7b1545fd3537791ebc36c",
     remote = "https://github.com/bmw-software-engineering/lobster.git",
 )

bazel/rules/rules_score/test/fixtures/image_srcs/BUILD

@@ -0,0 +1,47 @@
+# *******************************************************************************
+# Copyright (c) 2026 Contributors to the Eclipse Foundation
+#
+# See the NOTICE file(s) distributed with this work for additional
+# information regarding copyright ownership.
+#
+# This program and the accompanying materials are made available under the
+# terms of the Apache License Version 2.0 which is available at
+# https://www.apache.org/licenses/LICENSE-2.0
+#
+# SPDX-License-Identifier: Apache-2.0
+# *******************************************************************************
+
+# This sub-package exists so that ctx.label.package == "fixtures/image_srcs"
+# when feature_requirements stages image files.  subrule_trlc_image_stage
+# strips package_prefix from short_path to produce package-relative paths
+# (e.g. "diagrams/arch.png"); this only works when the package is not the
+# workspace root ("").
+
+load(
+    "@score_tooling//bazel/rules/rules_score:rules_score.bzl",
+    "feature_requirements",
+)
+load(
+    "//:requirements_image_test.bzl",
+    "image_srcs_sphinx_sources_test",
+    "requirements_image_test_suite",
+)
+
+package(default_visibility = ["//visibility:public"])
+
+feature_requirements(
+    name = "feat_req_with_image",
+    srcs = ["//:fixtures/seooc_test/feature_requirements.trlc"],
+    image_srcs = [
+        "diagrams/arch.svg",
+        "diagrams/arch.png",
+    ],
+    deps = ["//:asr_trlc"],
+)
+
+image_srcs_sphinx_sources_test(
+    name = "image_srcs_sphinx_sources_test",
+    target_under_test = ":feat_req_with_image",
+)
+
+requirements_image_test_suite(name = "requirements_image_tests")

bazel/rules/rules_score/test/trlc_rst_image_rendering_test.py

@@ -48,19 +48,11 @@ def setUp(self):
         self._tmpdir = tempfile.mkdtemp()
         self._out = os.path.join(self._tmpdir, "output.rst")
         self._fixture_trlc = _runfile(
-            "bazel",
-            "rules",
-            "rules_score",
-            "test",
             "fixtures",
             "image_requirements",
             "image_requirements.trlc",
         )
         self._fixture_rsl = _runfile(
-            "bazel",
-            "rules",
-            "rules_score",
-            "test",
             "fixtures",
             "image_requirements",
             "schema.rsl",