test(cpp/libclang): centralize parser integration case wiring

Author: melodyoncode

cpp/libclang/cpp_parser.bzl

@@ -352,6 +352,9 @@ def run_cpp_parser_action(
 # cpp_parser rule
 
 def _cpp_parser_impl(ctx):
+    if not has_cpp_parser_inputs(ctx.attr.target):
+        fail("cpp_parser requires a C/C++ target with non-empty parse inputs: %s" % ctx.attr.target)
+
     outputs = run_cpp_parser_action(
         ctx,
         target = ctx.attr.target,

cpp/libclang/integration_test/README.md

@@ -24,8 +24,16 @@ This directory contains integration tests for the C++ libclang parser and relate
 ## Test Workflow
 
 1. Each case directory contains C++ source files, headers, a BUILD file, and an `expected.json` golden output.
-2. The case `cpp_parser(...)` target must set `emit_debug_json = True` so the parser emits the aggregated `debug.json` sidecar required by the test harness.
-3. The Rust test framework reads `debug.json` from the parser output directory and compares it to `expected.json`.
+2. The case calls the shared integration test macro:
+   ```starlark
+   cpp_parser_integration_test(
+       name = "test_case_library",
+       target = ":case_library",
+       expected_output = ["expected.json"],
+   )
+   ```
+   The macro creates the expected output filegroup and parser target, exposes `CppParserInfo.debug_json` through the test-only debug JSON target, and wires the Rust comparison test.
+3. The Rust test framework receives that debug JSON path and compares it to `expected.json`.
 4. To batch test all cases:
 
 ```bash

cpp/libclang/integration_test/cases/complex_class/BUILD

@@ -10,14 +10,7 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
-load("//cpp/libclang:cpp_parser.bzl", "cpp_parser")
-
-filegroup(
-    name = "expected_output",
-    srcs = ["expected.json"],
-    visibility = ["//cpp/libclang/integration_test:__subpackages__"],
-)
+load("//cpp/libclang/integration_test:test_rules.bzl", "cpp_parser_integration_test")
 
 cc_library(
     name = "complex_class",
@@ -26,31 +19,8 @@ cc_library(
     visibility = ["//cpp/libclang:__subpackages__"],
 )
 
-cpp_parser(
-    name = "parser",
-    emit_debug_json = True,
-    extra_args = [
-    ],
+cpp_parser_integration_test(
+    name = "test_complex_class",
+    expected_output = ["expected.json"],
     target = ":complex_class",
-    tool = "//cpp/libclang:clang_rs_parser",
-    visibility = ["//cpp/libclang/integration_test:__pkg__"],
-)
-
-rust_test(
-    name = "test_libclang_parser",
-    srcs = [
-        "run_test.rs",
-    ],
-    data = [
-        ":expected_output",
-        ":parser",
-    ],
-    env = {
-        "TEST_OUTPUT_PATH": "$(rootpath :parser)",
-        "EXPECTED_OUTPUT_PATH": "$(rootpath :expected_output)",
-    },
-    visibility = ["//cpp/libclang:__pkg__"],
-    deps = [
-        "//cpp/libclang/integration_test:libclang_test_framework",
-    ],
 )

cpp/libclang/integration_test/cases/include_3rdparty/BUILD

@@ -10,14 +10,7 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
-load("//cpp/libclang:cpp_parser.bzl", "cpp_parser")
-
-filegroup(
-    name = "expected_output",
-    srcs = ["expected.json"],
-    visibility = ["//cpp/libclang/integration_test:__subpackages__"],
-)
+load("//cpp/libclang/integration_test:test_rules.bzl", "cpp_parser_integration_test")
 
 cc_library(
     name = "include_3rdparty",
@@ -29,31 +22,8 @@ cc_library(
     ],
 )
 
-cpp_parser(
-    name = "parser",
-    emit_debug_json = True,
-    extra_args = [
-    ],
+cpp_parser_integration_test(
+    name = "test_include_3rdparty",
+    expected_output = ["expected.json"],
     target = ":include_3rdparty",
-    tool = "//cpp/libclang:clang_rs_parser",
-    visibility = ["//cpp/libclang/integration_test:__pkg__"],
-)
-
-rust_test(
-    name = "test_libclang_parser",
-    srcs = [
-        "run_test.rs",
-    ],
-    data = [
-        ":expected_output",
-        ":parser",
-    ],
-    env = {
-        "TEST_OUTPUT_PATH": "$(rootpath :parser)",
-        "EXPECTED_OUTPUT_PATH": "$(rootpath :expected_output)",
-    },
-    visibility = ["//cpp/libclang:__pkg__"],
-    deps = [
-        "//cpp/libclang/integration_test:libclang_test_framework",
-    ],
 )

cpp/libclang/integration_test/cases/method_parameter_type/BUILD

@@ -10,45 +10,16 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-load("@rules_rust//rust:defs.bzl", "rust_test")
-load("//cpp/libclang:cpp_parser.bzl", "cpp_parser")
-
-filegroup(
-    name = "expected_output",
-    srcs = ["expected.json"],
-    visibility = ["//cpp/libclang/integration_test:__subpackages__"],
-)
+load("//cpp/libclang/integration_test:test_rules.bzl", "cpp_parser_integration_test")
 
 cc_library(
     name = "method_parameter_type",
     srcs = ["transport.cpp"],
     visibility = ["//cpp/libclang:__subpackages__"],
 )
 
-cpp_parser(
-    name = "parser",
-    emit_debug_json = True,
-    extra_args = [],
+cpp_parser_integration_test(
+    name = "test_method_parameter_type",
+    expected_output = ["expected.json"],
     target = ":method_parameter_type",
-    tool = "//cpp/libclang:clang_rs_parser",
-    visibility = ["//cpp/libclang/integration_test:__pkg__"],
-)
-
-rust_test(
-    name = "test_libclang_parser",
-    srcs = [
-        "run_test.rs",
-    ],
-    data = [
-        ":expected_output",
-        ":parser",
-    ],
-    env = {
-        "TEST_OUTPUT_PATH": "$(rootpath :parser)",
-        "EXPECTED_OUTPUT_PATH": "$(rootpath :expected_output)",
-    },
-    visibility = ["//cpp/libclang:__pkg__"],
-    deps = [
-        "//cpp/libclang/integration_test:libclang_test_framework",
-    ],
 )

cpp/libclang/integration_test/cases/method_return_type/BUILD

@@ -10,45 +10,16 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-load("@rules_rust//rust:defs.bzl", "rust_test")
-load("//cpp/libclang:cpp_parser.bzl", "cpp_parser")
-
-filegroup(
-    name = "expected_output",
-    srcs = ["expected.json"],
-    visibility = ["//cpp/libclang/integration_test:__subpackages__"],
-)
+load("//cpp/libclang/integration_test:test_rules.bzl", "cpp_parser_integration_test")
 
 cc_library(
     name = "method_return_type",
     srcs = ["transport.cpp"],
     visibility = ["//cpp/libclang:__subpackages__"],
 )
 
-cpp_parser(
-    name = "parser",
-    emit_debug_json = True,
-    extra_args = [],
+cpp_parser_integration_test(
+    name = "test_method_return_type",
+    expected_output = ["expected.json"],
     target = ":method_return_type",
-    tool = "//cpp/libclang:clang_rs_parser",
-    visibility = ["//cpp/libclang/integration_test:__pkg__"],
-)
-
-rust_test(
-    name = "test_libclang_parser",
-    srcs = [
-        "run_test.rs",
-    ],
-    data = [
-        ":expected_output",
-        ":parser",
-    ],
-    env = {
-        "TEST_OUTPUT_PATH": "$(rootpath :parser)",
-        "EXPECTED_OUTPUT_PATH": "$(rootpath :expected_output)",
-    },
-    visibility = ["//cpp/libclang:__pkg__"],
-    deps = [
-        "//cpp/libclang/integration_test:libclang_test_framework",
-    ],
 )

cpp/libclang/integration_test/cases/nest_namespace_class/BUILD

@@ -10,46 +10,16 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
-load("//cpp/libclang:cpp_parser.bzl", "cpp_parser")
-
-filegroup(
-    name = "expected_output",
-    srcs = ["expected.json"],
-    visibility = ["//cpp/libclang/integration_test:__subpackages__"],
-)
+load("//cpp/libclang/integration_test:test_rules.bzl", "cpp_parser_integration_test")
 
 cc_library(
     name = "nest_namespace_class",
     srcs = glob(["*.cpp"]),
     visibility = ["//cpp/libclang:__subpackages__"],
 )
 
-cpp_parser(
-    name = "parser",
-    emit_debug_json = True,
-    extra_args = [
-    ],
+cpp_parser_integration_test(
+    name = "test_nest_namespace_class",
+    expected_output = ["expected.json"],
     target = ":nest_namespace_class",
-    tool = "//cpp/libclang:clang_rs_parser",
-    visibility = ["//cpp/libclang/integration_test:__pkg__"],
-)
-
-rust_test(
-    name = "test_libclang_parser",
-    srcs = [
-        "run_test.rs",
-    ],
-    data = [
-        ":expected_output",
-        ":parser",
-    ],
-    env = {
-        "TEST_OUTPUT_PATH": "$(rootpath :parser)",
-        "EXPECTED_OUTPUT_PATH": "$(rootpath :expected_output)",
-    },
-    visibility = ["//cpp/libclang:__pkg__"],
-    deps = [
-        "//cpp/libclang/integration_test:libclang_test_framework",
-    ],
 )

cpp/libclang/integration_test/cases/relationship_aggregation/BUILD

@@ -10,46 +10,16 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
-load("//cpp/libclang:cpp_parser.bzl", "cpp_parser")
-
-filegroup(
-    name = "expected_output",
-    srcs = ["expected.json"],
-    visibility = ["//cpp/libclang/integration_test:__subpackages__"],
-)
+load("//cpp/libclang/integration_test:test_rules.bzl", "cpp_parser_integration_test")
 
 cc_library(
     name = "relationship_aggregation",
     srcs = ["aggregation.cpp"],
     visibility = ["//cpp/libclang:__subpackages__"],
 )
 
-cpp_parser(
-    name = "parser",
-    emit_debug_json = True,
-    extra_args = [
-    ],
+cpp_parser_integration_test(
+    name = "test_relationship_aggregation",
+    expected_output = ["expected.json"],
     target = ":relationship_aggregation",
-    tool = "//cpp/libclang:clang_rs_parser",
-    visibility = ["//cpp/libclang/integration_test:__pkg__"],
-)
-
-rust_test(
-    name = "test_libclang_parser",
-    srcs = [
-        "run_test.rs",
-    ],
-    data = [
-        ":expected_output",
-        ":parser",
-    ],
-    env = {
-        "TEST_OUTPUT_PATH": "$(rootpath :parser)",
-        "EXPECTED_OUTPUT_PATH": "$(rootpath :expected_output)",
-    },
-    visibility = ["//cpp/libclang:__pkg__"],
-    deps = [
-        "//cpp/libclang/integration_test:libclang_test_framework",
-    ],
 )

cpp/libclang/integration_test/cases/relationship_association/BUILD

@@ -10,46 +10,16 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 # *******************************************************************************
-load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
-load("//cpp/libclang:cpp_parser.bzl", "cpp_parser")
-
-filegroup(
-    name = "expected_output",
-    srcs = ["expected.json"],
-    visibility = ["//cpp/libclang/integration_test:__subpackages__"],
-)
+load("//cpp/libclang/integration_test:test_rules.bzl", "cpp_parser_integration_test")
 
 cc_library(
     name = "relationship_association",
     srcs = ["association.cpp"],
     visibility = ["//cpp/libclang:__subpackages__"],
 )
 
-cpp_parser(
-    name = "parser",
-    emit_debug_json = True,
-    extra_args = [
-    ],
+cpp_parser_integration_test(
+    name = "test_relationship_association",
+    expected_output = ["expected.json"],
     target = ":relationship_association",
-    tool = "//cpp/libclang:clang_rs_parser",
-    visibility = ["//cpp/libclang/integration_test:__pkg__"],
-)
-
-rust_test(
-    name = "test_libclang_parser",
-    srcs = [
-        "run_test.rs",
-    ],
-    data = [
-        ":expected_output",
-        ":parser",
-    ],
-    env = {
-        "TEST_OUTPUT_PATH": "$(rootpath :parser)",
-        "EXPECTED_OUTPUT_PATH": "$(rootpath :expected_output)",
-    },
-    visibility = ["//cpp/libclang:__pkg__"],
-    deps = [
-        "//cpp/libclang/integration_test:libclang_test_framework",
-    ],
 )