fix(sphinx_wrapper): fix swapped stdout/stderr redirects and remove s…#152
Merged
Conversation
…hadowed exit code redirect_stderr was incorrectly redirected to stdout_processor and redirect_stdout to stderr_processor. Also removes the unconditional exit_code = 0 assignment that was shadowing the actual return value from run_sphinx_build.
ramceb
requested review from
LittleHuba,
castler,
hoe-jo and
limdor
as code owners
hoe-jo
approved these changes
Apr 13, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in INF - Infrastructure Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hadowed exit code
redirect_stderr was incorrectly redirected to stdout_processor and redirect_stdout to stderr_processor. Also removes the unconditional exit_code = 0 assignment that was shadowing the actual return value from run_sphinx_build.