From c3393ce067322d3c7add8c53e87d9839fe5e6965 Mon Sep 17 00:00:00 2001 From: Jochen Hoenle <173445474+hoe-jo@users.noreply.github.com> Date: Tue, 21 Apr 2026 13:57:21 +0200 Subject: [PATCH 1/2] [rules_score] remove docs_as_code dependency --- MODULE.bazel | 5 ---- bazel/rules/rules_score/BUILD | 42 +++++------------------------- bazel/rules/rules_score/trlc/BUILD | 12 +++++++++ validation/ai_checker/BUILD | 5 +++- 4 files changed, 22 insertions(+), 42 deletions(-) create mode 100644 bazel/rules/rules_score/trlc/BUILD diff --git a/MODULE.bazel b/MODULE.bazel index 689a648e..951555ca 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -210,11 +210,6 @@ register_toolchains( "//bazel/rules/rules_score:sphinx_default_toolchain", ) -############################################################################### -# Dev Dependencies (for testing) -############################################################################### -bazel_dep(name = "score_docs_as_code", version = "3.0.1", dev_dependency = True) - ############################################################################### # Setup Googletest ############################################################################### diff --git a/bazel/rules/rules_score/BUILD b/bazel/rules/rules_score/BUILD index a853003c..a0b5f10f 100644 --- a/bazel/rules/rules_score/BUILD +++ b/bazel/rules/rules_score/BUILD @@ -72,40 +72,6 @@ py_library( ], ) -# Sphinx build binary with all required dependencies -py_binary( - name = "score_build", - srcs = ["src/sphinx_wrapper.py"], - data = [ - "//tools/sphinx:plantuml", - ], - env = { - "SOURCE_DIRECTORY": "", - "DATA": "", - "ACTION": "check", - }, - main = "src/sphinx_wrapper.py", - visibility = ["//visibility:public"], - deps = [ - ":sphinx_module_ext", - "@lobster//sphinx_lobster:sphinx_lobster_builder", - "@score_docs_as_code//src/extensions/score_metamodel", - "@score_tooling//plantuml/sphinx/clickable_plantuml", - "@trlc//tools/sphinx/extensions/trlc", - requirement("sphinx"), - requirement("sphinx_rtd_theme"), - requirement("sphinx_needs"), - requirement("sphinx_design"), - requirement("myst_parser"), - requirement("readthedocs_sphinx_ext"), - requirement("rst2pdf"), - requirement("sphinxcontrib-umlet"), - requirement("svglib"), - requirement("sphinxcontrib-plantuml"), - "@rules_python//python/runfiles", - ], -) - sphinx_module( name = "rules_score_doc", srcs = glob( @@ -124,6 +90,9 @@ sphinx_module( py_binary( name = "raw_build", srcs = ["src/sphinx_wrapper.py"], + data = [ + "//tools/sphinx:plantuml", + ], env = { "SOURCE_DIRECTORY": "", "DATA": "", @@ -132,8 +101,9 @@ py_binary( main = "src/sphinx_wrapper.py", visibility = ["//visibility:public"], deps = [ + ":sphinx_module_ext", "@lobster//sphinx_lobster:sphinx_lobster_builder", - "@score_docs_as_code//src/extensions/score_metamodel", + "@rules_python//python/runfiles", "@score_tooling//plantuml/sphinx/clickable_plantuml", "@trlc//tools/sphinx/extensions/trlc", requirement("sphinx"), @@ -151,7 +121,7 @@ py_binary( sphinx_toolchain( name = "default_toolchain", - sphinx = ":score_build", + sphinx = ":raw_build", ) toolchain_type(name = "toolchain_type") diff --git a/bazel/rules/rules_score/trlc/BUILD b/bazel/rules/rules_score/trlc/BUILD new file mode 100644 index 00000000..6bdeed2c --- /dev/null +++ b/bazel/rules/rules_score/trlc/BUILD @@ -0,0 +1,12 @@ +# ******************************************************************************* +# Copyright (c) 2025 Contributors to the Eclipse Foundation +# +# See the NOTICE file(s) distributed with this work for additional +# information regarding copyright ownership. +# +# This program and the accompanying materials are made available under the +# terms of the Apache License Version 2.0 which is available at +# https://www.apache.org/licenses/LICENSE-2.0 +# +# SPDX-License-Identifier: Apache-2.0 +# ******************************************************************************* diff --git a/validation/ai_checker/BUILD b/validation/ai_checker/BUILD index 991940b5..8fa84219 100644 --- a/validation/ai_checker/BUILD +++ b/validation/ai_checker/BUILD @@ -14,7 +14,10 @@ load("@pip_ai_checker//:requirements.bzl", "requirement") load("@rules_python//python:pip.bzl", "compile_pip_requirements") exports_files( - ["src/ai_checker/orchestrator.py"], + [ + "ai_checker.bzl", + "src/ai_checker/orchestrator.py", + ], visibility = ["//visibility:public"], ) From f45fec4d32150b874fa3288a553e60ebfb1a93ac Mon Sep 17 00:00:00 2001 From: Jochen Hoenle <173445474+hoe-jo@users.noreply.github.com> Date: Tue, 21 Apr 2026 13:59:58 +0200 Subject: [PATCH 2/2] [rules score]: adapt visibility Co-authored-by: SebSparrowHawk 211667837+SebSparrowHawk@users.noreply.github.com --- bazel/rules/rules_score/BUILD | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bazel/rules/rules_score/BUILD b/bazel/rules/rules_score/BUILD index a0b5f10f..4dcf0575 100644 --- a/bazel/rules/rules_score/BUILD +++ b/bazel/rules/rules_score/BUILD @@ -124,7 +124,10 @@ sphinx_toolchain( sphinx = ":raw_build", ) -toolchain_type(name = "toolchain_type") +toolchain_type( + name = "toolchain_type", + visibility = ["//visibility:public"], +) toolchain( name = "sphinx_default_toolchain",