Skip to content

Migrate tests to Junit5#252

Open
kamilkrzywanski wants to merge 3 commits into
eclipse-sisu:mainfrom
kamilkrzywanski:junit5_tests
Open

Migrate tests to Junit5#252
kamilkrzywanski wants to merge 3 commits into
eclipse-sisu:mainfrom
kamilkrzywanski:junit5_tests

Conversation

@kamilkrzywanski
Copy link
Copy Markdown

No description provided.

@cstamas
Copy link
Copy Markdown
Member

cstamas commented Apr 19, 2026

Cool beans!

But one remark: test classes in src/main/java should remain as is, their goal is to support third-party (those using Sisu) to write tests, and they may be using junit3/4/5 or testng....

So, while you migrate those, please do not "take away" the ability of rest (if possible).

@cstamas cstamas requested review from kwin and mcculls April 19, 2026 11:04
@kamilkrzywanski
Copy link
Copy Markdown
Author

@cstamas changes from src/main/java reverted

Comment thread org.eclipse.sisu.plexus/pom.xml Outdated
@cstamas
Copy link
Copy Markdown
Member

cstamas commented Apr 19, 2026

Failure is unrelated (Sonar)
@kwin

@cstamas cstamas added this to the 1.0.1 milestone May 27, 2026
@cstamas
Copy link
Copy Markdown
Member

cstamas commented May 27, 2026

Again: non committers "main" (ubuntu) job fails to perform scan, this is CI issue, and build itself was fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants